Title: [122089] trunk/Source
- Revision
- 122089
- Author
- [email protected]
- Date
- 2012-07-08 23:12:24 -0700 (Sun, 08 Jul 2012)
Log Message
Introduce a build flag for low quality JPEG images
https://bugs.webkit.org/show_bug.cgi?id=90748
Reviewed by Adam Barth.
Source/WebCore:
Introduce build options for no JPEG dithering (USE(LOW_QUALITY_IMAGE_NO_JPEG_DITHERING))
and no JPEG fancy upsampling (USE(LOW_QUALITY_IMAGE_NO_JPEG_FANCY_UPSAMPLING)).
No new tests as there is no change in functionality.
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(ditherMode):
(doFancyUpsampling):
Source/WTF:
Turn on the newly introduced flags for android.
* wtf/Platform.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (122088 => 122089)
--- trunk/Source/WTF/ChangeLog 2012-07-09 05:10:20 UTC (rev 122088)
+++ trunk/Source/WTF/ChangeLog 2012-07-09 06:12:24 UTC (rev 122089)
@@ -1,3 +1,14 @@
+2012-07-08 Laszlo Gombos <[email protected]>
+
+ Introduce a build flag for low quality JPEG images
+ https://bugs.webkit.org/show_bug.cgi?id=90748
+
+ Reviewed by Adam Barth.
+
+ Turn on the newly introduced flags for android.
+
+ * wtf/Platform.h:
+
2012-07-05 Filip Pizlo <[email protected]>
INLINE_ARM_FUNCTION(thingy) should make thingy be thumb2 if we're using thumb2
Modified: trunk/Source/WTF/wtf/Platform.h (122088 => 122089)
--- trunk/Source/WTF/wtf/Platform.h 2012-07-09 05:10:20 UTC (rev 122088)
+++ trunk/Source/WTF/wtf/Platform.h 2012-07-09 06:12:24 UTC (rev 122089)
@@ -475,6 +475,8 @@
#elif OS(ANDROID)
#define WTF_USE_SKIA 1
#define WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION 1
+#define WTF_USE_LOW_QUALITY_IMAGE_NO_JPEG_DITHERING 1
+#define WTF_USE_LOW_QUALITY_IMAGE_NO_JPEG_FANCY_UPSAMPLING 1
#else
#define WTF_USE_SKIA 1
#define WTF_USE_ICCJPEG 1
Modified: trunk/Source/WebCore/ChangeLog (122088 => 122089)
--- trunk/Source/WebCore/ChangeLog 2012-07-09 05:10:20 UTC (rev 122088)
+++ trunk/Source/WebCore/ChangeLog 2012-07-09 06:12:24 UTC (rev 122089)
@@ -1,3 +1,19 @@
+2012-07-08 Laszlo Gombos <[email protected]>
+
+ Introduce a build flag for low quality JPEG images
+ https://bugs.webkit.org/show_bug.cgi?id=90748
+
+ Reviewed by Adam Barth.
+
+ Introduce build options for no JPEG dithering (USE(LOW_QUALITY_IMAGE_NO_JPEG_DITHERING))
+ and no JPEG fancy upsampling (USE(LOW_QUALITY_IMAGE_NO_JPEG_FANCY_UPSAMPLING)).
+
+ No new tests as there is no change in functionality.
+
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+ (ditherMode):
+ (doFancyUpsampling):
+
2012-07-08 Sheriff Bot <[email protected]>
Unreviewed, rolling out r121968.
Modified: trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp (122088 => 122089)
--- trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp 2012-07-09 05:10:20 UTC (rev 122088)
+++ trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp 2012-07-09 06:12:24 UTC (rev 122089)
@@ -86,13 +86,17 @@
inline bool colorSpaceHasAlpha(J_COLOR_SPACE) { return false; }
#endif
-#if OS(ANDROID)
+#if USE(LOW_QUALITY_IMAGE_NO_JPEG_DITHERING)
inline J_DCT_METHOD dctMethod() { return JDCT_IFAST; }
inline J_DITHER_MODE ditherMode() { return JDITHER_NONE; }
-inline bool doFancyUpsampling() { return false; }
#else
inline J_DCT_METHOD dctMethod() { return JDCT_ISLOW; }
inline J_DITHER_MODE ditherMode() { return JDITHER_FS; }
+#endif
+
+#if USE(LOW_QUALITY_IMAGE_NO_JPEG_FANCY_UPSAMPLING)
+inline bool doFancyUpsampling() { return false; }
+#else
inline bool doFancyUpsampling() { return true; }
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
