Title: [122103] trunk/Source/WebCore
- Revision
- 122103
- Author
- [email protected]
- Date
- 2012-07-09 05:28:12 -0700 (Mon, 09 Jul 2012)
Log Message
[SOUP] Use soup_cookie_jar_is_persistent() to set whether cookie is a session one or not
https://bugs.webkit.org/show_bug.cgi?id=90769
Reviewed by Gustavo Noronha Silva.
It's currently set to false, because there were no API to know
whether cookies were persistent or not. Now that we bumped libsoup
requirements, we can use soup_cookie_jar_is_persistent().
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122102 => 122103)
--- trunk/Source/WebCore/ChangeLog 2012-07-09 11:36:37 UTC (rev 122102)
+++ trunk/Source/WebCore/ChangeLog 2012-07-09 12:28:12 UTC (rev 122103)
@@ -1,3 +1,17 @@
+2012-07-09 Carlos Garcia Campos <[email protected]>
+
+ [SOUP] Use soup_cookie_jar_is_persistent() to set whether cookie is a session one or not
+ https://bugs.webkit.org/show_bug.cgi?id=90769
+
+ Reviewed by Gustavo Noronha Silva.
+
+ It's currently set to false, because there were no API to know
+ whether cookies were persistent or not. Now that we bumped libsoup
+ requirements, we can use soup_cookie_jar_is_persistent().
+
+ * platform/network/soup/CookieJarSoup.cpp:
+ (WebCore::getRawCookies):
+
2012-07-09 Taiju Tsuiki <[email protected]>
Web Inspector: Add text file support for FileSystemAgent::requestFileContent
Modified: trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp (122102 => 122103)
--- trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp 2012-07-09 11:36:37 UTC (rev 122102)
+++ trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp 2012-07-09 12:28:12 UTC (rev 122103)
@@ -162,11 +162,9 @@
GOwnPtr<SoupCookie> cookie(static_cast<SoupCookie*>(iter->data));
if (!soup_cookie_applies_to_uri(cookie.get(), uri.get()))
continue;
- // FIXME: we are currently passing false always for session because there's no API to know
- // whether SoupCookieJar is persistent or not. We could probably add soup_cookie_jar_is_persistent().
rawCookies.append(Cookie(String::fromUTF8(cookie->name), String::fromUTF8(cookie->value), String::fromUTF8(cookie->domain),
String::fromUTF8(cookie->path), static_cast<double>(soup_date_to_time_t(cookie->expires)) * 1000,
- cookie->http_only, cookie->secure, false));
+ cookie->http_only, cookie->secure, soup_cookie_jar_is_persistent(jar)));
}
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
