- Revision
- 122435
- Author
- [email protected]
- Date
- 2012-07-12 02:46:55 -0700 (Thu, 12 Jul 2012)
Log Message
[IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()
https://bugs.webkit.org/show_bug.cgi?id=90867
Patch by Xingnan Wang <[email protected]> on 2012-07-12
Reviewed by Tony Chang.
Source/WebCore:
In the latest W3C spec upperOpen/lowerOpen are set to true in lowerBound()/upperBound(), which
we should keep aligned with.
No new tests - updated storage/indexeddb/keyrange.html to match new behavior.
* Modules/indexeddb/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
LayoutTests:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/resources/keyrange.js:
(checkLowerBoundKeyRange):
(checkUpperBoundKeyRange):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (122434 => 122435)
--- trunk/LayoutTests/ChangeLog 2012-07-12 09:37:29 UTC (rev 122434)
+++ trunk/LayoutTests/ChangeLog 2012-07-12 09:46:55 UTC (rev 122435)
@@ -1,3 +1,15 @@
+2012-07-12 Xingnan Wang <[email protected]>
+
+ [IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()
+ https://bugs.webkit.org/show_bug.cgi?id=90867
+
+ Reviewed by Tony Chang.
+
+ * storage/indexeddb/keyrange-expected.txt:
+ * storage/indexeddb/resources/keyrange.js:
+ (checkLowerBoundKeyRange):
+ (checkUpperBoundKeyRange):
+
2012-07-12 Kristóf Kosztyó <[email protected]>
[Qt] Unreviewed gardening. Skip the new failing test.
Modified: trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt (122434 => 122435)
--- trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt 2012-07-12 09:37:29 UTC (rev 122434)
+++ trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt 2012-07-12 09:46:55 UTC (rev 122435)
@@ -43,92 +43,92 @@
PASS keyRange.lower is 10
PASS keyRange.lowerOpen is true
PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
IDBKeyRange.lowerBound(11,false)
PASS keyRange.lower is 11
PASS keyRange.lowerOpen is false
PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
IDBKeyRange.lowerBound(12,undefined)
PASS keyRange.lower is 12
PASS keyRange.lowerOpen is false
PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
IDBKeyRange.lowerBound(10.1,true)
PASS keyRange.lower is 10.1
PASS keyRange.lowerOpen is true
PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
IDBKeyRange.lowerBound(11.2,false)
PASS keyRange.lower is 11.2
PASS keyRange.lowerOpen is false
PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
IDBKeyRange.lowerBound(12.3,undefined)
PASS keyRange.lower is 12.3
PASS keyRange.lowerOpen is false
PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
IDBKeyRange.lowerBound('aa',true)
PASS keyRange.lower is 'aa'
PASS keyRange.lowerOpen is true
PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
IDBKeyRange.lowerBound('ab',false)
PASS keyRange.lower is 'ab'
PASS keyRange.lowerOpen is false
PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
IDBKeyRange.lowerBound('ac',undefined)
PASS keyRange.lower is 'ac'
PASS keyRange.lowerOpen is false
PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
IDBKeyRange.upperBound(20,true)
PASS keyRange.upper is 20
PASS keyRange.upperOpen is true
PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
IDBKeyRange.upperBound(21,false)
PASS keyRange.upper is 21
PASS keyRange.upperOpen is false
PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
IDBKeyRange.upperBound(22,undefined)
PASS keyRange.upper is 22
PASS keyRange.upperOpen is false
PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
IDBKeyRange.upperBound(20.2,true)
PASS keyRange.upper is 20.2
PASS keyRange.upperOpen is true
PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
IDBKeyRange.upperBound(21.3,false)
PASS keyRange.upper is 21.3
PASS keyRange.upperOpen is false
PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
IDBKeyRange.upperBound(22.4,undefined)
PASS keyRange.upper is 22.4
PASS keyRange.upperOpen is false
PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
IDBKeyRange.upperBound('ba',true)
PASS keyRange.upper is 'ba'
PASS keyRange.upperOpen is true
PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
IDBKeyRange.upperBound('bb',false)
PASS keyRange.upper is 'bb'
PASS keyRange.upperOpen is false
PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
IDBKeyRange.upperBound('bc',undefined)
PASS keyRange.upper is 'bc'
PASS keyRange.upperOpen is false
PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
IDBKeyRange.bound(30,40, undefined, undefined)
PASS keyRange.lower is 30
PASS keyRange.upper is 40
Modified: trunk/LayoutTests/storage/indexeddb/resources/keyrange.js (122434 => 122435)
--- trunk/LayoutTests/storage/indexeddb/resources/keyrange.js 2012-07-12 09:37:29 UTC (rev 122434)
+++ trunk/LayoutTests/storage/indexeddb/resources/keyrange.js 2012-07-12 09:46:55 UTC (rev 122435)
@@ -22,7 +22,7 @@
open = false;
shouldBe("keyRange.lowerOpen", "" + open);
shouldBeNull("keyRange.upper");
- shouldBeFalse("keyRange.upperOpen");
+ shouldBeTrue("keyRange.upperOpen");
}
function checkUpperBoundKeyRange(value, open)
@@ -33,7 +33,7 @@
open = false;
shouldBe("keyRange.upperOpen", "" + open);
shouldBeNull("keyRange.lower");
- shouldBeFalse("keyRange.lowerOpen");
+ shouldBeTrue("keyRange.lowerOpen");
}
function checkBoundKeyRange(lower, upper, lowerOpen, upperOpen)
@@ -154,4 +154,4 @@
test();
-finishJSTest();
\ No newline at end of file
+finishJSTest();
Modified: trunk/Source/WebCore/ChangeLog (122434 => 122435)
--- trunk/Source/WebCore/ChangeLog 2012-07-12 09:37:29 UTC (rev 122434)
+++ trunk/Source/WebCore/ChangeLog 2012-07-12 09:46:55 UTC (rev 122435)
@@ -1,3 +1,19 @@
+2012-07-12 Xingnan Wang <[email protected]>
+
+ [IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()
+ https://bugs.webkit.org/show_bug.cgi?id=90867
+
+ Reviewed by Tony Chang.
+
+ In the latest W3C spec upperOpen/lowerOpen are set to true in lowerBound()/upperBound(), which
+ we should keep aligned with.
+
+ No new tests - updated storage/indexeddb/keyrange.html to match new behavior.
+
+ * Modules/indexeddb/IDBKeyRange.cpp:
+ (WebCore::IDBKeyRange::lowerBound):
+ (WebCore::IDBKeyRange::upperBound):
+
2012-07-12 MORITA Hajime <[email protected]>
[Shadow DOM] <video> with <shadow> crashes
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp (122434 => 122435)
--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp 2012-07-12 09:37:29 UTC (rev 122434)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp 2012-07-12 09:46:55 UTC (rev 122435)
@@ -59,7 +59,7 @@
return 0;
}
- return IDBKeyRange::create(bound, 0, open ? LowerBoundOpen : LowerBoundClosed, UpperBoundClosed);
+ return IDBKeyRange::create(bound, 0, open ? LowerBoundOpen : LowerBoundClosed, UpperBoundOpen);
}
PassRefPtr<IDBKeyRange> IDBKeyRange::upperBound(PassRefPtr<IDBKey> bound, bool open, ExceptionCode& ec)
@@ -69,7 +69,7 @@
return 0;
}
- return IDBKeyRange::create(0, bound, LowerBoundClosed, open ? UpperBoundOpen : UpperBoundClosed);
+ return IDBKeyRange::create(0, bound, LowerBoundOpen, open ? UpperBoundOpen : UpperBoundClosed);
}
PassRefPtr<IDBKeyRange> IDBKeyRange::bound(PassRefPtr<IDBKey> lower, PassRefPtr<IDBKey> upper, bool lowerOpen, bool upperOpen, ExceptionCode& ec)
