Title: [122565] trunk/Source/WebKit2
- Revision
- 122565
- Author
- [email protected]
- Date
- 2012-07-13 04:44:10 -0700 (Fri, 13 Jul 2012)
Log Message
[GTK] WebKitWebView::mouse-target-changed is not emitted when moved to/from edtiable content
https://bugs.webkit.org/show_bug.cgi?id=91216
Reviewed by Xan Lopez.
The problem is that the function to check whether two hit test
results are equal doesn't check the editable flag.
* UIProcess/API/gtk/WebKitHitTestResult.cpp:
(webkitHitTestResultCompare): Check also the editable flag.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (122564 => 122565)
--- trunk/Source/WebKit2/ChangeLog 2012-07-13 11:43:43 UTC (rev 122564)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-13 11:44:10 UTC (rev 122565)
@@ -1,3 +1,16 @@
+2012-07-13 Carlos Garcia Campos <[email protected]>
+
+ [GTK] WebKitWebView::mouse-target-changed is not emitted when moved to/from edtiable content
+ https://bugs.webkit.org/show_bug.cgi?id=91216
+
+ Reviewed by Xan Lopez.
+
+ The problem is that the function to check whether two hit test
+ results are equal doesn't check the editable flag.
+
+ * UIProcess/API/gtk/WebKitHitTestResult.cpp:
+ (webkitHitTestResultCompare): Check also the editable flag.
+
2012-07-13 Gyuyoung Kim <[email protected]>
[EFL] Add *explicit* keyword to constructor which has a parameter
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp (122564 => 122565)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp 2012-07-13 11:43:43 UTC (rev 122564)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp 2012-07-13 11:44:10 UTC (rev 122565)
@@ -277,7 +277,8 @@
bool webkitHitTestResultCompare(WebKitHitTestResult* hitTestResult, WKHitTestResultRef wkHitTestResult)
{
WebKitHitTestResultPrivate* priv = hitTestResult->priv;
- return stringIsEqualToCString(toImpl(wkHitTestResult)->absoluteLinkURL(), priv->linkURI)
+ return WKHitTestResultIsContentEditable(wkHitTestResult) == webkit_hit_test_result_context_is_editable(hitTestResult)
+ && stringIsEqualToCString(toImpl(wkHitTestResult)->absoluteLinkURL(), priv->linkURI)
&& stringIsEqualToCString(toImpl(wkHitTestResult)->linkTitle(), priv->linkTitle)
&& stringIsEqualToCString(toImpl(wkHitTestResult)->linkLabel(), priv->linkLabel)
&& stringIsEqualToCString(toImpl(wkHitTestResult)->absoluteImageURL(), priv->imageURI)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes