Title: [122812] trunk/Source/WebCore
- Revision
- 122812
- Author
- [email protected]
- Date
- 2012-07-17 00:08:17 -0700 (Tue, 17 Jul 2012)
Log Message
Attempt to fix the Chromium Mac build after <http://trac.webkit.org/changeset/122802>
(https://bugs.webkit.org/show_bug.cgi?id=91451)
Remove unused private instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.
This instance variable has remained unused since it was added in
<http://trac.webkit.org/changeset/116718> (https://bugs.webkit.org/show_bug.cgi?id=85725).
I'm unclear as to why the Chromium Mac build began to complain about this
unused instance variable following <http://trac.webkit.org/changeset/122802>, since this
code has been in the tree for a while and we previously instantiated AbsoluteQuadsGeneratorContext
with wasFixed (even though it wasn't used). Regardless, we should remove the unused
instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.
* rendering/RenderInline.cpp:
(WebCore): Remove AbsoluteQuadsGeneratorContext::m_wasFixed.
(WebCore::RenderInline::absoluteQuads):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122811 => 122812)
--- trunk/Source/WebCore/ChangeLog 2012-07-17 06:43:41 UTC (rev 122811)
+++ trunk/Source/WebCore/ChangeLog 2012-07-17 07:08:17 UTC (rev 122812)
@@ -1,3 +1,22 @@
+2012-07-16 Daniel Bates <[email protected]>
+
+ Attempt to fix the Chromium Mac build after <http://trac.webkit.org/changeset/122802>
+ (https://bugs.webkit.org/show_bug.cgi?id=91451)
+
+ Remove unused private instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.
+ This instance variable has remained unused since it was added in
+ <http://trac.webkit.org/changeset/116718> (https://bugs.webkit.org/show_bug.cgi?id=85725).
+
+ I'm unclear as to why the Chromium Mac build began to complain about this
+ unused instance variable following <http://trac.webkit.org/changeset/122802>, since this
+ code has been in the tree for a while and we previously instantiated AbsoluteQuadsGeneratorContext
+ with wasFixed (even though it wasn't used). Regardless, we should remove the unused
+ instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.
+
+ * rendering/RenderInline.cpp:
+ (WebCore): Remove AbsoluteQuadsGeneratorContext::m_wasFixed.
+ (WebCore::RenderInline::absoluteQuads):
+
2012-07-16 Gyuyoung Kim <[email protected]>
Add RegisterProtocolHandlerClient to the Modules/protocolhandler
Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (122811 => 122812)
--- trunk/Source/WebCore/rendering/RenderInline.cpp 2012-07-17 06:43:41 UTC (rev 122811)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp 2012-07-17 07:08:17 UTC (rev 122812)
@@ -648,9 +648,8 @@
class AbsoluteQuadsGeneratorContext {
public:
- AbsoluteQuadsGeneratorContext(const RenderInline* renderer, Vector<FloatQuad>& quads, bool* wasFixed)
+ AbsoluteQuadsGeneratorContext(const RenderInline* renderer, Vector<FloatQuad>& quads)
: m_quads(quads)
- , m_wasFixed(wasFixed)
, m_geometryMap()
{
m_geometryMap.pushMappingsToAncestor(renderer, 0);
@@ -662,7 +661,6 @@
}
private:
Vector<FloatQuad>& m_quads;
- bool* m_wasFixed;
RenderGeometryMap m_geometryMap;
};
@@ -670,7 +668,7 @@
void RenderInline::absoluteQuads(Vector<FloatQuad>& quads, bool* wasFixed) const
{
- AbsoluteQuadsGeneratorContext context(this, quads, wasFixed);
+ AbsoluteQuadsGeneratorContext context(this, quads);
generateLineBoxRects(context);
if (continuation())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
