Diff
Modified: trunk/LayoutTests/ChangeLog (122814 => 122815)
--- trunk/LayoutTests/ChangeLog 2012-07-17 07:19:25 UTC (rev 122814)
+++ trunk/LayoutTests/ChangeLog 2012-07-17 07:23:18 UTC (rev 122815)
@@ -1,3 +1,30 @@
+2012-07-17 Yoshifumi Inoue <[email protected]>
+
+ [Forms] Test expectations of datetime/datetime-local/time should not contain milliseconds when they aren't expected
+ https://bugs.webkit.org/show_bug.cgi?id=91469
+
+ Reviewed by Kent Tamura.
+
+ This patch gets rid of unexpected millisecond strings from both test
+ cases and expected text.
+
+ This is adaptation of behavior change caused by r119948, introducing
+ decimal arithmetic, which corrected the _expression_ step mod 1000 used
+ in BaseDateAndTimeInputType::serialize for checking adding milliseconds
+ or not, which converts internal date time representation into string.
+
+ Before r119948, we used fmod(step, 1000) for this. However, it doesn't
+ return mathematically correct value when quotient is very large, e.g.
+ fmod(3.40282346e+38, 1000) returns 616 on x86 linux, although we
+ expect that it is 0.
+
+ * fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Get rid of millig seconds for big step value tests.
+ * fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: ditto.
+ * fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: ditto.
+ * fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: ditto.
+ * fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Get rid of millig seconds for a big step value test and expected value's fractinal second is zero.
+ * fast/forms/time/time-stepup-stepdown-from-renderer.html: ditto.
+
2012-07-17 Kristóf Kosztyó <[email protected]>
[Qt] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt (122814 => 122815)
--- trunk/LayoutTests/fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt 2012-07-17 07:19:25 UTC (rev 122814)
+++ trunk/LayoutTests/fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt 2012-07-17 07:23:18 UTC (rev 122815)
@@ -15,8 +15,8 @@
PASS stepUp("2010-02-10T20:13Z", "any", null) is "2010-02-10T20:14Z"
PASS stepDown("2010-02-10T20:13Z", "any", null) is "2010-02-10T20:12Z"
Overflow/underflow
-PASS stepUp("2010-02-10T20:13Z", "3.40282346e+38", null) is "275760-09-13T00:00:00.000Z"
-PASS stepDown("2010-02-10T20:13Z", "3.40282346e+38", null) is "1970-01-01T00:00:00.000Z"
+PASS stepUp("2010-02-10T20:13Z", "3.40282346e+38", null) is "275760-09-13T00:00:00Z"
+PASS stepDown("2010-02-10T20:13Z", "3.40282346e+38", null) is "1970-01-01T00:00:00Z"
PASS stepUp("2010-02-10T20:13Z", "1", "2010-02-10T20:13Z") is "2010-02-10T20:13Z"
PASS stepDown("2010-02-10T20:13Z", "1", "2010-02-10T20:13Z") is "2010-02-10T20:13Z"
stepDown()/stepUp() for stepMismatch values
Modified: trunk/LayoutTests/fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html (122814 => 122815)
--- trunk/LayoutTests/fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html 2012-07-17 07:19:25 UTC (rev 122814)
+++ trunk/LayoutTests/fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html 2012-07-17 07:23:18 UTC (rev 122815)
@@ -66,8 +66,8 @@
shouldBe('stepUp("2010-02-10T20:13Z", "any", null)', '"2010-02-10T20:14Z"');
shouldBe('stepDown("2010-02-10T20:13Z", "any", null)', '"2010-02-10T20:12Z"');
debug('Overflow/underflow');
-shouldBe('stepUp("2010-02-10T20:13Z", "3.40282346e+38", null)', '"275760-09-13T00:00:00.000Z"');
-shouldBe('stepDown("2010-02-10T20:13Z", "3.40282346e+38", null)', '"1970-01-01T00:00:00.000Z"');
+shouldBe('stepUp("2010-02-10T20:13Z", "3.40282346e+38", null)', '"275760-09-13T00:00:00Z"');
+shouldBe('stepDown("2010-02-10T20:13Z", "3.40282346e+38", null)', '"1970-01-01T00:00:00Z"');
shouldBe('stepUp("2010-02-10T20:13Z", "1", "2010-02-10T20:13Z")', '"2010-02-10T20:13Z"');
shouldBe('stepDown("2010-02-10T20:13Z", "1", "2010-02-10T20:13Z")', '"2010-02-10T20:13Z"');
debug('stepDown()/stepUp() for stepMismatch values');
Modified: trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt (122814 => 122815)
--- trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt 2012-07-17 07:19:25 UTC (rev 122814)
+++ trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt 2012-07-17 07:23:18 UTC (rev 122815)
@@ -15,8 +15,8 @@
PASS stepUp("2010-02-10T20:13", "any", null) is "2010-02-10T20:14"
PASS stepDown("2010-02-10T20:13", "any", null) is "2010-02-10T20:12"
Overflow/underflow
-PASS stepUp("2010-02-10T20:13", "3.40282346e+38", null) is "275760-09-13T00:00:00.000"
-PASS stepDown("2010-02-10T20:13", "3.40282346e+38", null) is "1970-01-01T00:00:00.000"
+PASS stepUp("2010-02-10T20:13", "3.40282346e+38", null) is "275760-09-13T00:00:00"
+PASS stepDown("2010-02-10T20:13", "3.40282346e+38", null) is "1970-01-01T00:00:00"
PASS stepUp("2010-02-10T20:13", "1", "2010-02-10T20:13") is "2010-02-10T20:13"
PASS stepDown("2010-02-10T20:13", "1", "2010-02-10T20:13") is "2010-02-10T20:13"
stepDown()/stepUp() for stepMismatch values
Modified: trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html (122814 => 122815)
--- trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html 2012-07-17 07:19:25 UTC (rev 122814)
+++ trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html 2012-07-17 07:23:18 UTC (rev 122815)
@@ -66,8 +66,8 @@
shouldBe('stepUp("2010-02-10T20:13", "any", null)', '"2010-02-10T20:14"');
shouldBe('stepDown("2010-02-10T20:13", "any", null)', '"2010-02-10T20:12"');
debug('Overflow/underflow');
-shouldBe('stepUp("2010-02-10T20:13", "3.40282346e+38", null)', '"275760-09-13T00:00:00.000"');
-shouldBe('stepDown("2010-02-10T20:13", "3.40282346e+38", null)', '"1970-01-01T00:00:00.000"');
+shouldBe('stepUp("2010-02-10T20:13", "3.40282346e+38", null)', '"275760-09-13T00:00:00"');
+shouldBe('stepDown("2010-02-10T20:13", "3.40282346e+38", null)', '"1970-01-01T00:00:00"');
shouldBe('stepUp("2010-02-10T20:13", "1", "2010-02-10T20:13")', '"2010-02-10T20:13"');
shouldBe('stepDown("2010-02-10T20:13", "1", "2010-02-10T20:13")', '"2010-02-10T20:13"');
debug('stepDown()/stepUp() for stepMismatch values');
Modified: trunk/LayoutTests/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt (122814 => 122815)
--- trunk/LayoutTests/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt 2012-07-17 07:19:25 UTC (rev 122814)
+++ trunk/LayoutTests/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt 2012-07-17 07:23:18 UTC (rev 122815)
@@ -16,7 +16,7 @@
PASS stepDown("20:13", "any", null) is "20:12"
Overflow/underflow
PASS stepUp("20:13", "3.40282346e+38", null) is "23:59:59.999"
-PASS stepDown("20:13", "3.40282346e+38", null) is "00:00:00.000"
+PASS stepDown("20:13", "3.40282346e+38", null) is "00:00:00"
PASS stepUp("20:13", "1", "20:13") is "20:13"
PASS stepDown("20:13", "1", "20:13") is "20:13"
PASS stepUp("23:59", null, null) is "23:59"
Modified: trunk/LayoutTests/fast/forms/time/time-stepup-stepdown-from-renderer.html (122814 => 122815)
--- trunk/LayoutTests/fast/forms/time/time-stepup-stepdown-from-renderer.html 2012-07-17 07:19:25 UTC (rev 122814)
+++ trunk/LayoutTests/fast/forms/time/time-stepup-stepdown-from-renderer.html 2012-07-17 07:23:18 UTC (rev 122815)
@@ -67,7 +67,7 @@
shouldBe('stepDown("20:13", "any", null)', '"20:12"');
debug('Overflow/underflow');
shouldBe('stepUp("20:13", "3.40282346e+38", null)', '"23:59:59.999"');
-shouldBe('stepDown("20:13", "3.40282346e+38", null)', '"00:00:00.000"');
+shouldBe('stepDown("20:13", "3.40282346e+38", null)', '"00:00:00"');
shouldBe('stepUp("20:13", "1", "20:13")', '"20:13"');
shouldBe('stepDown("20:13", "1", "20:13")', '"20:13"');
shouldBe('stepUp("23:59", null, null)', '"23:59"');
