Title: [122937] trunk/Source/WebCore
- Revision
- 122937
- Author
- [email protected]
- Date
- 2012-07-18 02:47:28 -0700 (Wed, 18 Jul 2012)
Log Message
REGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type month
https://bugs.webkit.org/show_bug.cgi?id=91603
Reviewed by Kent Tamura.
This patch restores default step base value to 0 (=1970-01) as before
r117738.
No new tests. Existing test(fast/forms/month/month-stepup-stepdown-from-renderer.html)
covers this case, although it is disabled.
* html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange): Changed default value of
step base to defaultMonthStepBase instead of DateComponents::minimumMonth().
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122936 => 122937)
--- trunk/Source/WebCore/ChangeLog 2012-07-18 08:57:47 UTC (rev 122936)
+++ trunk/Source/WebCore/ChangeLog 2012-07-18 09:47:28 UTC (rev 122937)
@@ -1,3 +1,20 @@
+2012-07-18 Yoshifumi Inoue <[email protected]>
+
+ REGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type month
+ https://bugs.webkit.org/show_bug.cgi?id=91603
+
+ Reviewed by Kent Tamura.
+
+ This patch restores default step base value to 0 (=1970-01) as before
+ r117738.
+
+ No new tests. Existing test(fast/forms/month/month-stepup-stepdown-from-renderer.html)
+ covers this case, although it is disabled.
+
+ * html/MonthInputType.cpp:
+ (WebCore::MonthInputType::createStepRange): Changed default value of
+ step base to defaultMonthStepBase instead of DateComponents::minimumMonth().
+
2012-07-18 Ryuan Choi <[email protected]>
[EFL] Cursor is not drawn when opengl_x11 backend is choosen.
Modified: trunk/Source/WebCore/html/MonthInputType.cpp (122936 => 122937)
--- trunk/Source/WebCore/html/MonthInputType.cpp 2012-07-18 08:57:47 UTC (rev 122936)
+++ trunk/Source/WebCore/html/MonthInputType.cpp 2012-07-18 09:47:28 UTC (rev 122937)
@@ -101,7 +101,7 @@
{
DEFINE_STATIC_LOCAL(const StepRange::StepDescription, stepDescription, (monthDefaultStep, monthDefaultStepBase, monthStepScaleFactor, StepRange::ParsedStepValueShouldBeInteger));
- const Decimal stepBase = parseToNumber(element()->fastGetAttribute(minAttr), Decimal::fromDouble(DateComponents::minimumMonth()));
+ const Decimal stepBase = parseToNumber(element()->fastGetAttribute(minAttr), Decimal::fromDouble(monthDefaultStepBase));
const Decimal minimum = parseToNumber(element()->fastGetAttribute(minAttr), Decimal::fromDouble(DateComponents::minimumMonth()));
const Decimal maximum = parseToNumber(element()->fastGetAttribute(maxAttr), Decimal::fromDouble(DateComponents::maximumMonth()));
const Decimal step = StepRange::parseStep(anyStepHandling, stepDescription, element()->fastGetAttribute(stepAttr));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
