Title: [123233] trunk/Source/WebCore
Revision
123233
Author
ad...@chromium.org
Date
2012-07-20 10:56:12 -0700 (Fri, 20 Jul 2012)

Log Message

CodeGeneratorInspector.py is unnecessarily chatty
https://bugs.webkit.org/show_bug.cgi?id=91758

Reviewed by Vsevolod Vlasov.

The code aded in r123091 included a "print" statement for each written
file. This makes for noisy build output, especially noticeable in the
Chromium ninja build (where build output takes up a single line of the
console).

If this print statement is generally useful, it should be
hidden behind a --verbose commandline option, as we do for the binding
generators.

* inspector/CodeGeneratorInspector.py:
(SmartOutput.close): Remove print statement.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (123232 => 123233)


--- trunk/Source/WebCore/ChangeLog	2012-07-20 17:53:03 UTC (rev 123232)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 17:56:12 UTC (rev 123233)
@@ -1,3 +1,22 @@
+2012-07-20  Adam Klein  <ad...@chromium.org>
+
+        CodeGeneratorInspector.py is unnecessarily chatty
+        https://bugs.webkit.org/show_bug.cgi?id=91758
+
+        Reviewed by Vsevolod Vlasov.
+
+        The code aded in r123091 included a "print" statement for each written
+        file. This makes for noisy build output, especially noticeable in the
+        Chromium ninja build (where build output takes up a single line of the
+        console).
+
+        If this print statement is generally useful, it should be
+        hidden behind a --verbose commandline option, as we do for the binding
+        generators.
+
+        * inspector/CodeGeneratorInspector.py:
+        (SmartOutput.close): Remove print statement.
+
 2012-07-20  Stephen White  <senorbla...@chromium.org>
 
         [chromium] Enable GPU-accelerated skia implementation of

Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (123232 => 123233)


--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-07-20 17:53:03 UTC (rev 123232)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-07-20 17:56:12 UTC (rev 123233)
@@ -2975,7 +2975,6 @@
             pass
 
         if text_changed:
-            print "    writing " + self.file_name_
             out_file = open(self.file_name_, "w")
             out_file.write(self.output_)
             out_file.close()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to