Title: [123580] trunk/Tools
- Revision
- 123580
- Author
- [email protected]
- Date
- 2012-07-24 23:40:49 -0700 (Tue, 24 Jul 2012)
Log Message
The EWS bots get flaky when we hit the failure limit
https://bugs.webkit.org/show_bug.cgi?id=92212
Reviewed by Eric Seidel.
Previously we were missing some failure types, which means we didn't
notice that the bots were hitting the failure limit.
* Scripts/webkitpy/common/net/layouttestresults.py:
(LayoutTestResults.failing_test_results):
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
(LayoutTestResultsTest.test_results_from_string):
(LayoutTestResultsTest.test_tests_matching_failure_types):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (123579 => 123580)
--- trunk/Tools/ChangeLog 2012-07-25 06:01:25 UTC (rev 123579)
+++ trunk/Tools/ChangeLog 2012-07-25 06:40:49 UTC (rev 123580)
@@ -1,3 +1,19 @@
+2012-07-24 Adam Barth <[email protected]>
+
+ The EWS bots get flaky when we hit the failure limit
+ https://bugs.webkit.org/show_bug.cgi?id=92212
+
+ Reviewed by Eric Seidel.
+
+ Previously we were missing some failure types, which means we didn't
+ notice that the bots were hitting the failure limit.
+
+ * Scripts/webkitpy/common/net/layouttestresults.py:
+ (LayoutTestResults.failing_test_results):
+ * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
+ (LayoutTestResultsTest.test_results_from_string):
+ (LayoutTestResultsTest.test_tests_matching_failure_types):
+
2012-07-24 Raphael Kubo da Costa <[email protected]>
[EFL] Unreviewed build fix.
Modified: trunk/Tools/Scripts/webkitpy/common/net/layouttestresults.py (123579 => 123580)
--- trunk/Tools/Scripts/webkitpy/common/net/layouttestresults.py 2012-07-25 06:01:25 UTC (rev 123579)
+++ trunk/Tools/Scripts/webkitpy/common/net/layouttestresults.py 2012-07-25 06:40:49 UTC (rev 123580)
@@ -168,9 +168,7 @@
return [result.test_name for result in self.results_matching_failure_types(failure_types)]
def failing_test_results(self):
- # These should match the "fail", "crash", and "timeout" keys.
- failure_types = [test_failures.FailureTextMismatch, test_failures.FailureImageHashMismatch, test_failures.FailureCrash, test_failures.FailureTimeout]
- return self.results_matching_failure_types(failure_types)
+ return self.results_matching_failure_types(test_failures.ALL_FAILURE_CLASSES)
def failing_tests(self):
return [result.test_name for result in self.failing_test_results()] + self._unit_test_failures
Modified: trunk/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py (123579 => 123580)
--- trunk/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py 2012-07-25 06:01:25 UTC (rev 123579)
+++ trunk/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py 2012-07-25 06:40:49 UTC (rev 123580)
@@ -138,9 +138,9 @@
self.assertEqual(LayoutTestResults.results_from_string(None), None)
self.assertEqual(LayoutTestResults.results_from_string(""), None)
results = LayoutTestResults.results_from_string(ORWTResultsHTMLParserTest._example_results_html)
- self.assertEqual(len(results.failing_tests()), 0)
+ self.assertEqual(len(results.failing_tests()), 1)
def test_tests_matching_failure_types(self):
results = LayoutTestResults.results_from_string(ORWTResultsHTMLParserTest._example_results_html_with_failing_tests)
failing_tests = results.tests_matching_failure_types([test_failures.FailureTextMismatch])
- self.assertEqual(len(results.failing_tests()), 1)
+ self.assertEqual(len(results.failing_tests()), 2)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
