Title: [123853] trunk
- Revision
- 123853
- Author
- [email protected]
- Date
- 2012-07-27 02:26:24 -0700 (Fri, 27 Jul 2012)
Log Message
Source/WebCore: Web Inspector: Move formatting support from _javascript_Source to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373
Reviewed by Pavel Feldman.
Moved formatting support from _javascript_Source to UISourceCode.
Extracted Formatter interface from ScriptFormatter and created IdentityFormatter
implememntation and Formatter.createFormatter(contentType) formatter factory.
Introduced virtual formattedChanged() method on UISourceCode.
* inspector/front-end/_javascript_Source.js:
(WebInspector._javascript_Source):
(WebInspector._javascript_Source.prototype.uiLocationToRawLocation):
(WebInspector._javascript_Source.prototype.breakpointStorageId):
(WebInspector._javascript_Source.prototype.searchInContent):
(WebInspector._javascript_Source.prototype.formattedChanged):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.Formatter):
(WebInspector.Formatter.createFormatter):
(WebInspector.Formatter.locationToPosition):
(WebInspector.Formatter.positionToLocation):
(WebInspector.Formatter.prototype.formatContent):
(WebInspector.ScriptFormatter):
(WebInspector.IdentityFormatter):
(WebInspector.IdentityFormatter.prototype.formatContent):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._fireContentAvailable):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.overrideLocation):
(WebInspector.UISourceCode.prototype.togglingFormatter):
(WebInspector.UISourceCode.prototype.formatted):
(WebInspector.UISourceCode.prototype.setFormatted.if):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
(WebInspector.UISourceCode.prototype.createFormatter):
(WebInspector.UISourceCode.prototype.formattedChanged):
Source/WebKit2: [EFL][WK2] Add unit tests for Ewk_View form client
https://bugs.webkit.org/show_bug.cgi?id=92468
Reviewed by Simon Hausmann.
Add unit test for form client functionality in
Ewk_View.
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(onFormAboutToBeSubmitted):
(TEST_F):
LayoutTests: Web Inspector: Move formatting support from _javascript_Source to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373
Reviewed by Pavel Feldman.
* inspector/debugger/script-formatter.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (123852 => 123853)
--- trunk/LayoutTests/ChangeLog 2012-07-27 08:50:31 UTC (rev 123852)
+++ trunk/LayoutTests/ChangeLog 2012-07-27 09:26:24 UTC (rev 123853)
@@ -18,6 +18,17 @@
* platform/qt/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
* platform/qt/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
+2012-07-27 János Badics <[email protected]>
+
+ [Qt] Unreviewed, rebaseline for tests introduced in r123790
+
+ Rubber stamped by Zoltan Herczeg.
+
+ * platform/qt/css3/filters/effect-brightness-clamping-expected.png: Added.
+ * platform/qt/css3/filters/effect-brightness-clamping-expected.txt: Added.
+ * platform/qt/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
+ * platform/qt/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
+
2012-07-27 Alec Flett <[email protected]>
IndexedDB: inject index keys on cursor/objectstore/index get success handlers
Modified: trunk/Source/WebCore/ChangeLog (123852 => 123853)
--- trunk/Source/WebCore/ChangeLog 2012-07-27 08:50:31 UTC (rev 123852)
+++ trunk/Source/WebCore/ChangeLog 2012-07-27 09:26:24 UTC (rev 123853)
@@ -99,6 +99,49 @@
* loader/cache/CachedScript.h:
(CachedScript):
+2012-07-27 Huang Dongsung <[email protected]>
+
+ Gather the duplicated timer code into CachedResource.
+ https://bugs.webkit.org/show_bug.cgi?id=92332
+
+ Reviewed by Nate Chapin.
+
+ Internal review by Jae Hyun Park.
+
+ When all clients are removed, CachedImage, CachedScript and CachedCSSStyleSheet
+ start the timer to destroy decoded data. Those three classes have their own
+ timer.
+ Changed CachedCSSStyleSheet::didAddClient to call super class method in order to
+ stop the timer. This change does not have any side effect because
+ CachedResource::didAddClient only stops the timer in this case.
+
+ No new tests - no new testable functionality.
+
+ * loader/cache/CachedCSSStyleSheet.cpp:
+ (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
+ (WebCore::CachedCSSStyleSheet::didAddClient):
+ * loader/cache/CachedCSSStyleSheet.h:
+ (CachedCSSStyleSheet):
+ * loader/cache/CachedImage.cpp:
+ (WebCore::CachedImage::CachedImage):
+ (WebCore::CachedImage::didAddClient):
+ (WebCore::CachedImage::allClientsRemoved):
+ * loader/cache/CachedImage.h:
+ (CachedImage):
+ * loader/cache/CachedResource.cpp:
+ (WebCore::CachedResource::CachedResource):
+ (WebCore::CachedResource::didAddClient):
+ (WebCore::CachedResource::removeClient):
+ (WebCore::CachedResource::destroyDecodedDataIfNeeded):
+ (WebCore):
+ (WebCore::CachedResource::decodedDataDeletionTimerFired):
+ * loader/cache/CachedResource.h:
+ (CachedResource):
+ * loader/cache/CachedScript.cpp:
+ (WebCore::CachedScript::CachedScript):
+ * loader/cache/CachedScript.h:
+ (CachedScript):
+
2012-07-27 Dana Jansens <[email protected]>
[chromium] Don't add a HUD layer when there is no rootLayer
Modified: trunk/Source/WebKit2/ChangeLog (123852 => 123853)
--- trunk/Source/WebKit2/ChangeLog 2012-07-27 08:50:31 UTC (rev 123852)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-27 09:26:24 UTC (rev 123853)
@@ -1,3 +1,17 @@
+2012-07-27 Christophe Dumez <[email protected]>
+
+ [EFL][WK2] Add unit tests for Ewk_View form client
+ https://bugs.webkit.org/show_bug.cgi?id=92468
+
+ Reviewed by Simon Hausmann.
+
+ Add unit test for form client functionality in
+ Ewk_View.
+
+ * UIProcess/API/efl/tests/test_ewk2_view.cpp:
+ (onFormAboutToBeSubmitted):
+ (TEST_F):
+
2012-07-26 Zeno Albisser <[email protected]>
Unreviewed Qt buildfix after r123786.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp (123852 => 123853)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp 2012-07-27 08:50:31 UTC (rev 123852)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp 2012-07-27 09:26:24 UTC (rev 123853)
@@ -60,3 +60,54 @@
ASSERT_TRUE(ewk_view_setting_encoding_custom_set(webView(), 0));
ASSERT_FALSE(ewk_view_setting_encoding_custom_get(webView()));
}
+
+static void onFormAboutToBeSubmitted(void* userData, Evas_Object*, void* eventInfo)
+{
+ Ewk_Form_Submission_Request* request = static_cast<Ewk_Form_Submission_Request*>(eventInfo);
+ bool* handled = static_cast<bool*>(userData);
+
+ ASSERT_TRUE(request);
+
+ Eina_List* fieldNames = ewk_form_submission_request_field_names_get(request);
+ ASSERT_TRUE(fieldNames);
+ ASSERT_EQ(eina_list_count(fieldNames), 3);
+ void* data;
+ EINA_LIST_FREE(fieldNames, data)
+ eina_stringshare_del(static_cast<char*>(data));
+
+ const char* value1 = ewk_form_submission_request_field_value_get(request, "text1");
+ ASSERT_STREQ(value1, "value1");
+ eina_stringshare_del(value1);
+ const char* value2 = ewk_form_submission_request_field_value_get(request, "text2");
+ ASSERT_STREQ(value2, "value2");
+ eina_stringshare_del(value2);
+ const char* password = ewk_form_submission_request_field_value_get(request, "password");
+ ASSERT_STREQ(password, "secret");
+ eina_stringshare_del(password);
+
+ *handled = true;
+}
+
+TEST_F(EWK2UnitTestBase, ewk_view_form_submission_request)
+{
+ const char* formHTML =
+ "<html><head><script type='text/_javascript_'>function submitForm() { document.getElementById('myform').submit(); }</script></head>"
+ "<body _onload_='submitForm()'>"
+ " <form id='myform' action=''>"
+ " <input type='text' name='text1' value='value1'>"
+ " <input type='text' name='text2' value='value2'>"
+ " <input type='password' name='password' value='secret'>"
+ " <textarea cols='5' rows='5' name='textarea'>Text</textarea>"
+ " <input type='hidden' name='hidden1' value='hidden1'>"
+ " <input type='submit' value='Submit'>"
+ " </form>"
+ "</body></html>";
+
+ ewk_view_html_string_load(webView(), formHTML, "file:///", 0);
+ bool handled = false;
+ evas_object_smart_callback_add(webView(), "form,submission,request", onFormAboutToBeSubmitted, &handled);
+ while (!handled)
+ ecore_main_loop_iterate();
+ ASSERT_TRUE(handled);
+ evas_object_smart_callback_del(webView(), "form,submission,request", onFormAboutToBeSubmitted);
+}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
