Title: [124001] trunk/Tools
Revision
124001
Author
[email protected]
Date
2012-07-30 00:58:25 -0700 (Mon, 30 Jul 2012)

Log Message

[EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
https://bugs.webkit.org/show_bug.cgi?id=92366

Patch by Mikhail Pozdnyakov <[email protected]> on 2012-07-30
Reviewed by Antonio Gomes.

Add SHIFT modifier for capital letters as VK_
codes do not distinguish between lows and caps and also to be consistent
with other ports which send caps as lowercase letters with the shift key down.

* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::keyDown):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (124000 => 124001)


--- trunk/Tools/ChangeLog	2012-07-30 07:54:54 UTC (rev 124000)
+++ trunk/Tools/ChangeLog	2012-07-30 07:58:25 UTC (rev 124001)
@@ -1,3 +1,17 @@
+2012-07-30  Mikhail Pozdnyakov  <[email protected]>
+
+        [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
+        https://bugs.webkit.org/show_bug.cgi?id=92366
+
+        Reviewed by Antonio Gomes.
+
+        Add SHIFT modifier for capital letters as VK_
+        codes do not distinguish between lows and caps and also to be consistent
+        with other ports which send caps as lowercase letters with the shift key down.
+
+        * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
+        (WTR::EventSenderProxy::keyDown):
+
 2012-07-29  Raphael Kubo da Costa  <[email protected]>
 
         [EFL][jhbuild] Make run-with-jhbuild become the jhbuild process itself.

Modified: trunk/Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp (124000 => 124001)


--- trunk/Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp	2012-07-30 07:54:54 UTC (rev 124000)
+++ trunk/Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp	2012-07-30 07:58:25 UTC (rev 124001)
@@ -401,6 +401,10 @@
     const char* keyName = keyEventInfo->keyName.data();
     const char* keyString = keyEventInfo->keyString.data();
 
+    // Enforce 'Shift' modifier for caps.
+    if ((strlen(keyName) == 1) && (keyName[0] >= 'A' && keyName[0] <= 'Z'))
+        wkModifiers |= kWKEventModifiersShiftKey;
+
     Evas* evas = ecore_evas_get(m_testController->mainWebView()->platformWindow());
     setEvasModifiers(evas, wkModifiers);
     evas_event_feed_key_down(evas, keyName, keyName, keyString, 0, 0, 0);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to