Title: [124007] trunk/Source/WebCore
- Revision
- 124007
- Author
- [email protected]
- Date
- 2012-07-30 02:25:21 -0700 (Mon, 30 Jul 2012)
Log Message
Web Inspector: element tag disappears after editing
https://bugs.webkit.org/show_bug.cgi?id=92385
Reviewed by Vsevolod Vlasov.
This has regressed when we started hiding elements panel upon
batch updates. Narrowing hiding cases, updating selection
in on-screen mode only.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.updateSelection):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124006 => 124007)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 09:05:11 UTC (rev 124006)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 09:25:21 UTC (rev 124007)
@@ -1,3 +1,17 @@
+2012-07-30 Pavel Feldman <[email protected]>
+
+ Web Inspector: element tag disappears after editing
+ https://bugs.webkit.org/show_bug.cgi?id=92385
+
+ Reviewed by Vsevolod Vlasov.
+
+ This has regressed when we started hiding elements panel upon
+ batch updates. Narrowing hiding cases, updating selection
+ in on-screen mode only.
+
+ * inspector/front-end/ElementsTreeOutline.js:
+ (WebInspector.ElementsTreeElement.prototype.updateSelection):
+
2012-07-26 Yury Semikhatsky <[email protected]>
Web Inspector: move StringImpl size calculation to StringImpl
Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (124006 => 124007)
--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-07-30 09:05:11 UTC (rev 124006)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-07-30 09:25:21 UTC (rev 124007)
@@ -2037,10 +2037,14 @@
}
var updatedParentTreeElements = [];
- var treeOutlineContainerElement = this._treeOutline.element.parentNode;
- var originalScrollTop = treeOutlineContainerElement ? treeOutlineContainerElement.scrollTop : 0;
- this._treeOutline.element.addStyleClass("hidden");
+ var hidePanelWhileUpdating = this._recentlyModifiedNodes.length > 10;
+ if (hidePanelWhileUpdating) {
+ var treeOutlineContainerElement = this._treeOutline.element.parentNode;
+ this._treeOutline.element.addStyleClass("hidden");
+ var originalScrollTop = treeOutlineContainerElement ? treeOutlineContainerElement.scrollTop : 0;
+ }
+
for (var i = 0; i < this._recentlyModifiedNodes.length; ++i) {
var parent = this._recentlyModifiedNodes[i].parent;
@@ -2074,9 +2078,12 @@
for (var i = 0; i < updatedParentTreeElements.length; ++i)
delete updatedParentTreeElements[i].alreadyUpdatedChildren;
- this._treeOutline.element.removeStyleClass("hidden");
- if (originalScrollTop)
- treeOutlineContainerElement.scrollTop = originalScrollTop;
+ if (hidePanelWhileUpdating) {
+ this._treeOutline.element.removeStyleClass("hidden");
+ if (originalScrollTop)
+ treeOutlineContainerElement.scrollTop = originalScrollTop;
+ this._treeOutline.updateSelection();
+ }
this._recentlyModifiedNodes = [];
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
