Title: [124047] trunk/LayoutTests
- Revision
- 124047
- Author
- commit-qu...@webkit.org
- Date
- 2012-07-30 10:41:47 -0700 (Mon, 30 Jul 2012)
Log Message
REGRESSION: Focused TR element draws its focus outline in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=85348
Patch by Pravin D <pravind....@gmail.com> on 2012-07-30
Reviewed by Julien Chaffraix.
The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
The issue was fixed by the bug http://www.webkit.org/b/92389 .
Adding a regression test case.
* fast/table/table-row-focus-ring-paint-expected.txt: Added.
* fast/table/table-row-focus-ring-paint.html: Added.
* platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
* platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (124046 => 124047)
--- trunk/LayoutTests/ChangeLog 2012-07-30 17:40:49 UTC (rev 124046)
+++ trunk/LayoutTests/ChangeLog 2012-07-30 17:41:47 UTC (rev 124047)
@@ -1,3 +1,19 @@
+2012-07-30 Pravin D <pravind....@gmail.com>
+
+ REGRESSION: Focused TR element draws its focus outline in the wrong place
+ https://bugs.webkit.org/show_bug.cgi?id=85348
+
+ Reviewed by Julien Chaffraix.
+
+ The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
+ The issue was fixed by the bug http://www.webkit.org/b/92389 .
+ Adding a regression test case.
+
+ * fast/table/table-row-focus-ring-paint-expected.txt: Added.
+ * fast/table/table-row-focus-ring-paint.html: Added.
+ * platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
+ * platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.
+
2012-07-30 Julien Chaffraix <jchaffr...@webkit.org>
ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect &)
Added: trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt (0 => 124047)
--- trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt 2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1 @@
+
Added: trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html (0 => 124047)
--- trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html (rev 0)
+++ trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html 2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+<head>
+<title> Testcase for bug https://bugs.webkit.org/show_bug.cgi?id=85348 </title>
+<!--
+Issue: The focus ring used be drawn around the first row irrespective of the current focused row. The issue was fixed by the bug
+ http://www.webkit.org/b/92389 .
+Description: The test case checks if the focus ring is drawn around currently focused table row.
+Expectation: Focus ring must be drawn around the green box and not around the yellow boxes.
+ -->
+<script>
+if(window.testRunner)
+ testRunner.dumpAsText(true);
+</script>
+</head>
+<body>
+<style>
+td {
+ width: 50px;
+ height: 50px;
+ background:yellow;
+ }
+</style>
+<table>
+ <tr>
+ <td></td>
+ </tr>
+ <tr id="row2" tabindex=0>
+ <td style="background:green"></td>
+ </tr>
+ <tr tabindex=0>
+ <td></td>
+ </tr>
+</table>
+<script>
+ document.getElementById('row2').focus();
+</script>
+</body>
+</html>
Added: trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png (0 => 124047)
--- trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png 2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1,7 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum e1d161da93b04cd8216f865f58169454\xCFd gIDATx\x9C\xED\xDC1N\xDB` \x86a\E\xCAP\x89\x84kй\xE9\x95z j\xB8X\xC3\xD7 \xC8\xE6\xC9\xDD\xDA"\xD1+\xA1\xE7\xED\xF8\xC6W\xAC\xF3<_ \xD0\xF9r\xEE \x9F\x8D\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\xD8\xEA\xB5\xC3+N\xE4?\xE8\x80\x8F\xC8
+ @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @l\xF5ځy\x89 \x9Fȋ\x815=\xED\xA6\xFDn\xB9!'Yo\xB6\xEB\xAB\xED\xB9W <3\xCC\xF3\x91;\xAA\xE9iwxכ\xEFw\xF7w\xCBoz\xA3\x9B\xEF7\xD3\xFE\xFE\xF2z\xD4X \xC0\x87r<\xB0\xE3\xC5\xC5|\xF9\xEDv\xB8\x9F\xF4V\xF3\xAF\xF9\xEF\xCEso \xF8\xC7G\xEE 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X \xB1\xD5ѧ\xEB\xCD\xF6\xF08Ɵ_\xDE\xF3\x87\x87q\xDA\xEF.\xAF\xC7s xf\x98\xE7\xF9\xE8\x8B\xE9i7\xED/\xBC\xE6\xBD֛\xEB\xAB\xED\xB9W <\xF3b` p\x9A\xE3?\xFEgXbʼn\xA4! \xF0\xF9\xC8 &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b &\xB0 b \xB6z\xED\xC0\xBC\xC4
+ \x80O\xC4
+ @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @\xECt\xDFE\x9E`FS7 IEND\xAEB`\x82
\ No newline at end of file
Added: trunk/LayoutTests/platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png (0 => 124047)
--- trunk/LayoutTests/platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png (rev 0)
+++ trunk/LayoutTests/platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png 2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR X \x9Av\x82p sBIT|d\x88 pHYs \xC4 \xC4\x95+ )tEXtchecksum b53ade2da02df4ea75bd3dae8a72a6d4\xACX\xF1
+aIDATx\x9C\xED\xDD\xC1j;EѮ\x90\xFF\xCE\xF3\x97+\x93/1q\xC0ڂh\xADQA\xD7@5\xF3\xA6N\xB7\x9F\xB5\xD6z \xBE\x9C>