Title: [124071] trunk/Tools
- Revision
- 124071
- Author
- dpra...@chromium.org
- Date
- 2012-07-30 11:55:10 -0700 (Mon, 30 Jul 2012)
Log Message
After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=92664
Reviewed by Michael Saboff.
Updated to handle crash_logs being returned as a tuple of (stderr, crash_log).
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.look_for_new_crash_logs):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (124070 => 124071)
--- trunk/Tools/ChangeLog 2012-07-30 18:54:59 UTC (rev 124070)
+++ trunk/Tools/ChangeLog 2012-07-30 18:55:10 UTC (rev 124071)
@@ -1,3 +1,15 @@
+2012-07-30 Dirk Pranke <dpra...@chromium.org>
+
+ After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
+ https://bugs.webkit.org/show_bug.cgi?id=92664
+
+ Reviewed by Michael Saboff.
+
+ Updated to handle crash_logs being returned as a tuple of (stderr, crash_log).
+
+ * Scripts/webkitpy/layout_tests/port/mac.py:
+ (MacPort.look_for_new_crash_logs):
+
2012-07-30 Stephen White <senorbla...@chromium.org>
Added a SkiaGraphics definition to the watchlist file; cc'ed myself
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (124070 => 124071)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-07-30 18:54:59 UTC (rev 124070)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-07-30 18:55:10 UTC (rev 124071)
@@ -235,7 +235,7 @@
for (test_name, process_name, pid) in crashed_processes:
# Passing None for output. This is a second pass after the test finished so
# if the output had any loggine we would have already collected it.
- crash_log = self._get_crash_log(process_name, pid, None, None, start_time, wait_for_log=False)
+ crash_log = self._get_crash_log(process_name, pid, None, None, start_time, wait_for_log=False)[1]
if not crash_log:
continue
crash_logs[test_name] = crash_log
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
