Title: [124283] trunk/Source/WebKit/chromium
- Revision
- 124283
- Author
- [email protected]
- Date
- 2012-07-31 19:04:25 -0700 (Tue, 31 Jul 2012)
Log Message
[chromium] Use the event bounding box when constructing a PlatformEvent::GestureTap
https://bugs.webkit.org/show_bug.cgi?id=92151
Patch by Terry Anderson <[email protected]> on 2012-07-31
Reviewed by Darin Fisher.
Now that gesture events store a bounding box, use |boundingBox| instead of
|deltaX| and |deltaY| when specifying |m_area|.
* public/WebInputEvent.h:
(WebGestureEvent):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (124282 => 124283)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-01 02:03:23 UTC (rev 124282)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-01 02:04:25 UTC (rev 124283)
@@ -1,3 +1,18 @@
+2012-07-31 Terry Anderson <[email protected]>
+
+ [chromium] Use the event bounding box when constructing a PlatformEvent::GestureTap
+ https://bugs.webkit.org/show_bug.cgi?id=92151
+
+ Reviewed by Darin Fisher.
+
+ Now that gesture events store a bounding box, use |boundingBox| instead of
+ |deltaX| and |deltaY| when specifying |m_area|.
+
+ * public/WebInputEvent.h:
+ (WebGestureEvent):
+ * src/WebInputEventConversion.cpp:
+ (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
+
2012-07-31 Sheriff Bot <[email protected]>
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/public/WebInputEvent.h (124282 => 124283)
--- trunk/Source/WebKit/chromium/public/WebInputEvent.h 2012-08-01 02:03:23 UTC (rev 124282)
+++ trunk/Source/WebKit/chromium/public/WebInputEvent.h 2012-08-01 02:04:25 UTC (rev 124283)
@@ -370,7 +370,7 @@
int globalX;
int globalY;
- // NOTE: |deltaX| and |deltaY| represents the amount to scroll for Scroll gesture events. For Pinch gesture events, |deltaX| represents the scaling/magnification factor. For a GestureTap event, |deltaX| and |deltaY| represent the horizontal and vertical radii of the touch region.
+ // NOTE: |deltaX| and |deltaY| represents the amount to scroll for Scroll gesture events. For Pinch gesture events, |deltaX| represents the scaling/magnification factor.
float deltaX;
float deltaY;
WebRect boundingBox;
Modified: trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp (124282 => 124283)
--- trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp 2012-08-01 02:03:23 UTC (rev 124282)
+++ trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp 2012-08-01 02:04:25 UTC (rev 124283)
@@ -152,7 +152,7 @@
break;
case WebInputEvent::GestureTap:
m_type = PlatformEvent::GestureTap;
- m_area = IntSize(e.deltaX * 2, e.deltaY * 2);
+ m_area = IntSize(e.boundingBox.width, e.boundingBox.height);
break;
case WebInputEvent::GestureTapDown:
m_type = PlatformEvent::GestureTapDown;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
