Title: [124337] trunk/Source/WebKit/blackberry
- Revision
- 124337
- Author
- [email protected]
- Date
- 2012-08-01 08:57:44 -0700 (Wed, 01 Aug 2012)
Log Message
[BlackBerry] Consolidate suppression of keyboard requests.
https://bugs.webkit.org/show_bug.cgi?id=92871
Reviewed by Antonio Gomes.
Reduce VKB requests even more by applying the filter on
all requests during processing.
Reviewed Internally by Gen Mak.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (124336 => 124337)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-08-01 15:45:28 UTC (rev 124336)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-08-01 15:57:44 UTC (rev 124337)
@@ -1,3 +1,19 @@
+2012-08-01 Mike Fenton <[email protected]>
+
+ [BlackBerry] Consolidate suppression of keyboard requests.
+ https://bugs.webkit.org/show_bug.cgi?id=92871
+
+ Reviewed by Antonio Gomes.
+
+ Reduce VKB requests even more by applying the filter on
+ all requests during processing.
+
+ Reviewed Internally by Gen Mak.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
+ (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
+
2012-08-01 Arvid Nilsson <[email protected]>
[BlackBerry] Disable tap highlight when transparent color is specified
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (124336 => 124337)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-08-01 15:45:28 UTC (rev 124336)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-08-01 15:57:44 UTC (rev 124337)
@@ -362,8 +362,7 @@
Node* node = frame->document()->focusedNode();
if (isActiveTextEdit() && m_currentFocusElement == node) {
- if (!processingChange())
- notifyClientOfKeyboardVisibilityChange(true);
+ notifyClientOfKeyboardVisibilityChange(true);
return;
}
@@ -1034,6 +1033,11 @@
if (!isInputModeEnabled() && visible)
return;
+ if (processingChange()) {
+ ASSERT(visible);
+ return;
+ }
+
if (!m_delayKeyboardVisibilityChange) {
m_webPage->showVirtualKeyboard(visible);
return;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
