Title: [124382] trunk/Source/WebKit/chromium
- Revision
- 124382
- Author
- jsb...@chromium.org
- Date
- 2012-08-01 16:15:49 -0700 (Wed, 01 Aug 2012)
Log Message
[Chromium] IndexedDB: API stubs to simplify WebIDBCursor API
https://bugs.webkit.org/show_bug.cgi?id=92414
Reviewed by Adam Barth.
Prep work to unblock Chromium changes so that http://webkit.org/b/92278 can land.
Adds no-op methods which will later be implemented; during the landing sequence,
Chromium will call both the new methods and the old ones. The end goal is that
the success callbacks for cursors will include the new key/primaryKey/value rather
than requiring the callee to call back into the cursor backend to fetch them.
* public/WebIDBCallbacks.h:
(WebIDBCallbacks):
(WebKit::WebIDBCallbacks::onSuccess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (124381 => 124382)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-01 23:12:50 UTC (rev 124381)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-01 23:15:49 UTC (rev 124382)
@@ -1,3 +1,20 @@
+2012-08-01 Joshua Bell <jsb...@chromium.org>
+
+ [Chromium] IndexedDB: API stubs to simplify WebIDBCursor API
+ https://bugs.webkit.org/show_bug.cgi?id=92414
+
+ Reviewed by Adam Barth.
+
+ Prep work to unblock Chromium changes so that http://webkit.org/b/92278 can land.
+ Adds no-op methods which will later be implemented; during the landing sequence,
+ Chromium will call both the new methods and the old ones. The end goal is that
+ the success callbacks for cursors will include the new key/primaryKey/value rather
+ than requiring the callee to call back into the cursor backend to fetch them.
+
+ * public/WebIDBCallbacks.h:
+ (WebIDBCallbacks):
+ (WebKit::WebIDBCallbacks::onSuccess):
+
2012-08-01 Peter Beverloo <pe...@chromium.org>
[Text Autosizing] Provide an API for influencing the font scale factor
Modified: trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h (124381 => 124382)
--- trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h 2012-08-01 23:12:50 UTC (rev 124381)
+++ trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h 2012-08-01 23:15:49 UTC (rev 124382)
@@ -51,12 +51,16 @@
virtual void onError(const WebIDBDatabaseError&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebDOMStringList&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(WebIDBCursor*) { WEBKIT_ASSERT_NOT_REACHED(); }
+ // FIXME: Temporary no-op method to allow callers to update before WK92278 lands.
+ virtual void onSuccess(WebIDBCursor*, const WebIDBKey& key, const WebIDBKey& primaryKey, const WebSerializedScriptValue&) { }
virtual void onSuccess(WebIDBDatabase*) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebIDBKey&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(WebIDBTransaction*) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebSerializedScriptValue&, const WebIDBKey&, const WebIDBKeyPath&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccessWithContinuation() { WEBKIT_ASSERT_NOT_REACHED(); }
+ // FIXME: Temporary no-op method to allow callers to update before WK92278 lands.
+ virtual void onSuccess(const WebIDBKey& key, const WebIDBKey& primaryKey, const WebSerializedScriptValue&) { }
virtual void onBlocked() { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onBlocked(long long oldVersion) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccessWithPrefetch(const WebVector<WebIDBKey>& keys, const WebVector<WebIDBKey>& primaryKeys, const WebVector<WebSerializedScriptValue>& values) { WEBKIT_ASSERT_NOT_REACHED(); }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
