Title: [124886] trunk/Source/WebCore
- Revision
- 124886
- Author
- vse...@chromium.org
- Date
- 2012-08-07 06:52:42 -0700 (Tue, 07 Aug 2012)
Log Message
Web Inspector: Do not disable network tracking while profiling cpu.
https://bugs.webkit.org/show_bug.cgi?id=93359
Reviewed by Yury Semikhatsky.
Removed network tracking enabling/disabling machinery.
* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileType.prototype.buttonClicked):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124885 => 124886)
--- trunk/Source/WebCore/ChangeLog 2012-08-07 13:52:02 UTC (rev 124885)
+++ trunk/Source/WebCore/ChangeLog 2012-08-07 13:52:42 UTC (rev 124886)
@@ -1,3 +1,21 @@
+2012-08-07 Vsevolod Vlasov <vse...@chromium.org>
+
+ Web Inspector: Do not disable network tracking while profiling cpu.
+ https://bugs.webkit.org/show_bug.cgi?id=93359
+
+ Reviewed by Yury Semikhatsky.
+
+ Removed network tracking enabling/disabling machinery.
+
+ * inspector/front-end/CPUProfileView.js:
+ (WebInspector.CPUProfileType.prototype.buttonClicked):
+ * inspector/front-end/NetworkManager.js:
+ (WebInspector.NetworkManager.get this):
+ (WebInspector.NetworkManager.get NetworkAgent):
+ (WebInspector.NetworkManager):
+ * inspector/front-end/ResourceTreeModel.js:
+ (WebInspector.ResourceTreeModel):
+
2012-08-07 Alexei Filippov <alex...@chromium.org>
Web Inspector: make the MemoryClassInfo class a not-template
Modified: trunk/Source/WebCore/inspector/front-end/CPUProfileView.js (124885 => 124886)
--- trunk/Source/WebCore/inspector/front-end/CPUProfileView.js 2012-08-07 13:52:02 UTC (rev 124885)
+++ trunk/Source/WebCore/inspector/front-end/CPUProfileView.js 2012-08-07 13:52:42 UTC (rev 124886)
@@ -560,10 +560,8 @@
{
if (this._recording) {
this.stopRecordingProfile();
- WebInspector.networkManager.enableResourceTracking();
return false;
} else {
- WebInspector.networkManager.disableResourceTracking();
this.startRecordingProfile();
return true;
}
Modified: trunk/Source/WebCore/inspector/front-end/NetworkManager.js (124885 => 124886)
--- trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2012-08-07 13:52:02 UTC (rev 124885)
+++ trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2012-08-07 13:52:42 UTC (rev 124886)
@@ -49,8 +49,6 @@
}
WebInspector.NetworkManager.EventTypes = {
- ResourceTrackingEnabled: "ResourceTrackingEnabled",
- ResourceTrackingDisabled: "ResourceTrackingDisabled",
RequestStarted: "RequestStarted",
RequestUpdated: "RequestUpdated",
RequestFinished: "RequestFinished",
@@ -94,24 +92,6 @@
}
WebInspector.NetworkManager.prototype = {
- enableResourceTracking: function()
- {
- function callback(error)
- {
- this.dispatchEventToListeners(WebInspector.NetworkManager.EventTypes.ResourceTrackingEnabled);
- }
- NetworkAgent.enable(callback.bind(this));
- },
-
- disableResourceTracking: function()
- {
- function callback(error)
- {
- this.dispatchEventToListeners(WebInspector.NetworkManager.EventTypes.ResourceTrackingDisabled);
- }
- NetworkAgent.disable(callback.bind(this));
- },
-
/**
* @param {string} url
* @return {WebInspector.NetworkRequest}
Modified: trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js (124885 => 124886)
--- trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js 2012-08-07 13:52:02 UTC (rev 124885)
+++ trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js 2012-08-07 13:52:42 UTC (rev 124886)
@@ -35,7 +35,6 @@
*/
WebInspector.ResourceTreeModel = function(networkManager)
{
- networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResourceTrackingEnabled, this._onResourceTrackingEnabled, this);
networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestUpdated, this._onRequestUpdated, this);
networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, this._onRequestUpdated, this);
networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestUpdateDropped, this._onRequestUpdateDropped, this);
@@ -68,11 +67,6 @@
}
WebInspector.ResourceTreeModel.prototype = {
- _onResourceTrackingEnabled: function()
- {
- this._fetchResourceTree();
- },
-
_fetchResourceTree: function()
{
this._frames = {};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
