Title: [125401] trunk/Tools
- Revision
- 125401
- Author
- commit-qu...@webkit.org
- Date
- 2012-08-13 02:29:30 -0700 (Mon, 13 Aug 2012)
Log Message
[TestNetscapePlugin][X11] Additional key up event handler routine is required
https://bugs.webkit.org/show_bug.cgi?id=91357
Patch by KwangYong Choi <ky0.c...@samsung.com> on 2012-08-13
Reviewed by Eric Seidel.
Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
has-focus.html on X11 architecture. The test can not be done without this patch.
All other ports implemented it already.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventX11): Modified key up event handler for X11
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (125400 => 125401)
--- trunk/Tools/ChangeLog 2012-08-13 09:28:25 UTC (rev 125400)
+++ trunk/Tools/ChangeLog 2012-08-13 09:29:30 UTC (rev 125401)
@@ -1,3 +1,17 @@
+2012-08-13 KwangYong Choi <ky0.c...@samsung.com>
+
+ [TestNetscapePlugin][X11] Additional key up event handler routine is required
+ https://bugs.webkit.org/show_bug.cgi?id=91357
+
+ Reviewed by Eric Seidel.
+
+ Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
+ has-focus.html on X11 architecture. The test can not be done without this patch.
+ All other ports implemented it already.
+
+ * DumpRenderTree/TestNetscapePlugIn/main.cpp:
+ (handleEventX11): Modified key up event handler for X11
+
2012-08-13 Christophe Dumez <christophe.du...@intel.com>
[EFL][WK2] Replace Skipped list by TestExpectations
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp (125400 => 125401)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp 2012-08-13 09:28:25 UTC (rev 125400)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp 2012-08-13 09:29:30 UTC (rev 125401)
@@ -671,6 +671,11 @@
// FIXME: extract key code
if (obj->eventLogging)
pluginLog(instance, "keyUp '%c'", keyEventToChar(&event->xkey));
+ if (obj->testKeyboardFocusForPlugins) {
+ obj->eventLogging = false;
+ obj->testKeyboardFocusForPlugins = FALSE;
+ executeScript(obj, "testRunner.notifyDone();");
+ }
break;
case GraphicsExpose:
if (obj->eventLogging)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes