Title: [125533] trunk
Revision
125533
Author
ser...@webkit.org
Date
2012-08-14 02:28:20 -0700 (Tue, 14 Aug 2012)

Log Message

[GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
https://bugs.webkit.org/show_bug.cgi?id=91083

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

After r122428 search_next()/search_prev() should return just 1 match
if the text is found.

* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerNext):
(testFindControllerPrevious):

Tools:

Unskipped a couple of API tests that should work fine from now on.

* Scripts/run-gtk-tests:
(TestRunner):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (125532 => 125533)


--- trunk/Source/WebKit2/ChangeLog	2012-08-14 09:21:21 UTC (rev 125532)
+++ trunk/Source/WebKit2/ChangeLog	2012-08-14 09:28:20 UTC (rev 125533)
@@ -1,3 +1,17 @@
+2012-08-14  Sergio Villar Senin  <svil...@igalia.com>
+
+        [GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
+        https://bugs.webkit.org/show_bug.cgi?id=91083
+
+        Reviewed by Carlos Garcia Campos.
+
+        After r122428 search_next()/search_prev() should return just 1 match
+        if the text is found.
+
+        * UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
+        (testFindControllerNext):
+        (testFindControllerPrevious):
+
 2012-08-13  Carlos Garcia Campos  <cgar...@igalia.com>
 
         [GTK] Implement smart separators for context menu in WebKit2 GTK+

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp (125532 => 125533)


--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp	2012-08-14 09:21:21 UTC (rev 125532)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp	2012-08-14 09:28:20 UTC (rev 125533)
@@ -165,14 +165,14 @@
     test->waitUntilFindFinished();
 
     g_assert(test->m_textFound);
-    g_assert(test->m_matchCount == 2);
+    g_assert(test->m_matchCount == 1);
     g_assert(!(webkit_find_controller_get_options(test->m_findController.get()) & WEBKIT_FIND_OPTIONS_BACKWARDS));
 
     webkit_find_controller_search_next(test->m_findController.get());
     test->waitUntilFindFinished();
 
     g_assert(!test->m_textFound);
-    g_assert(test->m_matchCount == 2);
+    g_assert(test->m_matchCount == 1);
     g_assert(!(webkit_find_controller_get_options(test->m_findController.get()) & WEBKIT_FIND_OPTIONS_BACKWARDS));
 }
 
@@ -191,14 +191,14 @@
     test->waitUntilFindFinished();
 
     g_assert(test->m_textFound);
-    g_assert(test->m_matchCount == 2);
+    g_assert(test->m_matchCount == 1);
     g_assert(!(webkit_find_controller_get_options(test->m_findController.get()) & WEBKIT_FIND_OPTIONS_BACKWARDS));
 
     webkit_find_controller_search_previous(test->m_findController.get());
     test->waitUntilFindFinished();
 
     g_assert(test->m_textFound);
-    g_assert(test->m_matchCount == 2);
+    g_assert(test->m_matchCount == 1);
     g_assert(webkit_find_controller_get_options(test->m_findController.get()) & WEBKIT_FIND_OPTIONS_BACKWARDS);
 }
 

Modified: trunk/Tools/ChangeLog (125532 => 125533)


--- trunk/Tools/ChangeLog	2012-08-14 09:21:21 UTC (rev 125532)
+++ trunk/Tools/ChangeLog	2012-08-14 09:28:20 UTC (rev 125533)
@@ -1,3 +1,15 @@
+2012-08-14  Sergio Villar Senin  <svil...@igalia.com>
+
+        [GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
+        https://bugs.webkit.org/show_bug.cgi?id=91083
+
+        Reviewed by Carlos Garcia Campos.
+
+        Unskipped a couple of API tests that should work fine from now on.
+
+        * Scripts/run-gtk-tests:
+        (TestRunner):
+
 2012-08-14  Kristóf Kosztyó  <kkris...@inf.u-szeged.hu>
 
         [NRWT] Compare results between different platforms

Modified: trunk/Tools/Scripts/run-gtk-tests (125532 => 125533)


--- trunk/Tools/Scripts/run-gtk-tests	2012-08-14 09:21:21 UTC (rev 125532)
+++ trunk/Tools/Scripts/run-gtk-tests	2012-08-14 09:28:20 UTC (rev 125533)
@@ -67,8 +67,6 @@
         SkippedTest("unittests/testwebinspector", "/webkit/webinspector/close-and-inspect", "Test is flaky in GTK Linux 32-bit Release bot", 82869),
         SkippedTest("WebKit2APITests/TestWebKitWebView", "/webkit2/WebKitWebView/mouse-target", "Test is flaky in GTK Linux 32-bit Release bot", 82866),
         SkippedTest("WebKit2APITests/TestResources", "/webkit2/WebKitWebView/resources", "Test is flaky in GTK Linux 32-bit Release bot", 82868),
-        SkippedTest("WebKit2APITests/TestWebKitFindController", "/webkit2/WebKitFindController/next", "Test fails ", 91083),
-        SkippedTest("WebKit2APITests/TestWebKitFindController", "/webkit2/WebKitFindController/previous", "Test fails", 91083),
         SkippedTest("WebKit2APITests/TestWebKitFindController", "/webkit2/WebKitFindController/hide", "Test  always fails in Xvfb", 89810),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.WKConnection", "Tests fail and time out out", 84959),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.RestoreSessionStateContainingFormData", "Session State is not implemented in GTK+ port", 84960),
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to