Title: [125588] trunk/Source/WebKit/blackberry
- Revision
- 125588
- Author
- mifen...@rim.com
- Date
- 2012-08-14 12:02:31 -0700 (Tue, 14 Aug 2012)
Log Message
[BlackBerry] Use Form helper functions to determine state in DOMSupport::isTextBasedContentEditableElement
https://bugs.webkit.org/show_bug.cgi?id=93992
Reviewed by Antonio Gomes.
Use form control helper functions to determine the editable state
of the input field.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (125587 => 125588)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-08-14 18:54:32 UTC (rev 125587)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-08-14 19:02:31 UTC (rev 125588)
@@ -1,5 +1,18 @@
2012-08-14 Mike Fenton <mifen...@rim.com>
+ [BlackBerry] Use Form helper functions to determine state in DOMSupport::isTextBasedContentEditableElement
+ https://bugs.webkit.org/show_bug.cgi?id=93992
+
+ Reviewed by Antonio Gomes.
+
+ Use form control helper functions to determine the editable state
+ of the input field.
+
+ * WebKitSupport/DOMSupport.cpp:
+ (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
+
+2012-08-14 Mike Fenton <mifen...@rim.com>
+
[BlackBerry] Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()
https://bugs.webkit.org/show_bug.cgi?id=93988
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp (125587 => 125588)
--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-08-14 18:54:32 UTC (rev 125587)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-08-14 19:02:31 UTC (rev 125588)
@@ -231,12 +231,9 @@
if (!element)
return false;
- if (element->isTextFormControl() && static_cast<HTMLTextFormControlElement*>(element)->readOnly())
+ if (element->isReadOnlyFormControl() || !element->isEnabledFormControl())
return false;
- if (!element->isEnabledFormControl())
- return false;
-
if (isPopupInputField(element))
return false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
