Title: [125624] trunk/Source/WebCore
- Revision
- 125624
- Author
- commit-qu...@webkit.org
- Date
- 2012-08-14 17:10:36 -0700 (Tue, 14 Aug 2012)
Log Message
Clear pattern to prevent timing problem between cancelVibration and vibrate
https://bugs.webkit.org/show_bug.cgi?id=93957
Patch by Kihong Kwon <kihong.k...@samsung.com> on 2012-08-14
Reviewed by Kentaro Hara.
There is a timing issue in the cancelVibration.
Since vibrate works based on timer, cancelVibration might be called
eariler than vibrate when cancelVibration is called just after vibrate call.
It can be prevented from clearing m_pattern in the cancelVibration.
* Modules/vibration/Vibration.cpp:
(WebCore::Vibration::cancelVibration):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (125623 => 125624)
--- trunk/Source/WebCore/ChangeLog 2012-08-15 00:08:22 UTC (rev 125623)
+++ trunk/Source/WebCore/ChangeLog 2012-08-15 00:10:36 UTC (rev 125624)
@@ -1,3 +1,18 @@
+2012-08-14 Kihong Kwon <kihong.k...@samsung.com>
+
+ Clear pattern to prevent timing problem between cancelVibration and vibrate
+ https://bugs.webkit.org/show_bug.cgi?id=93957
+
+ Reviewed by Kentaro Hara.
+
+ There is a timing issue in the cancelVibration.
+ Since vibrate works based on timer, cancelVibration might be called
+ eariler than vibrate when cancelVibration is called just after vibrate call.
+ It can be prevented from clearing m_pattern in the cancelVibration.
+
+ * Modules/vibration/Vibration.cpp:
+ (WebCore::Vibration::cancelVibration):
+
2012-08-14 Alexandru Chiculita <ach...@adobe.com>
Layout Test css3/filters/custom/custom-filter-animation.html is failing
Modified: trunk/Source/WebCore/Modules/vibration/Vibration.cpp (125623 => 125624)
--- trunk/Source/WebCore/Modules/vibration/Vibration.cpp 2012-08-15 00:08:22 UTC (rev 125623)
+++ trunk/Source/WebCore/Modules/vibration/Vibration.cpp 2012-08-15 00:10:36 UTC (rev 125624)
@@ -73,6 +73,7 @@
void Vibration::cancelVibration()
{
+ m_pattern.clear();
if (m_isVibrating) {
m_vibrationClient->cancelVibration();
m_isVibrating = false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
