Title: [126353] trunk/Tools
- Revision
- 126353
- Author
- [email protected]
- Date
- 2012-08-22 14:42:38 -0700 (Wed, 22 Aug 2012)
Log Message
REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
https://bugs.webkit.org/show_bug.cgi?id=94704
Reviewed by Dirk Pranke.
Use tolerance=0 when acquiring diff image of reftest output.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_output_with_reference):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (126352 => 126353)
--- trunk/Tools/ChangeLog 2012-08-22 21:29:05 UTC (rev 126352)
+++ trunk/Tools/ChangeLog 2012-08-22 21:42:38 UTC (rev 126353)
@@ -1,3 +1,15 @@
+2012-08-22 Zan Dobersek <[email protected]>
+
+ REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
+ https://bugs.webkit.org/show_bug.cgi?id=94704
+
+ Reviewed by Dirk Pranke.
+
+ Use tolerance=0 when acquiring diff image of reftest output.
+
+ * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+ (SingleTestRunner._compare_output_with_reference):
+
2012-08-22 Tommy Widenflycht <[email protected]>
[chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (126352 => 126353)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2012-08-22 21:29:05 UTC (rev 126352)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2012-08-22 21:42:38 UTC (rev 126353)
@@ -321,14 +321,14 @@
failures.append(test_failures.FailureReftestNoImagesGenerated(reference_filename))
elif mismatch:
if reference_driver_output.image_hash == actual_driver_output.image_hash:
- diff_result = self._port.diff_image(reference_driver_output.image, actual_driver_output.image)
+ diff_result = self._port.diff_image(reference_driver_output.image, actual_driver_output.image, tolerance=0)
if not diff_result[0]:
failures.append(test_failures.FailureReftestMismatchDidNotOccur(reference_filename))
else:
_log.warning(" %s -> ref test hashes matched but diff failed" % self._test_name)
elif reference_driver_output.image_hash != actual_driver_output.image_hash:
- diff_result = self._port.diff_image(reference_driver_output.image, actual_driver_output.image)
+ diff_result = self._port.diff_image(reference_driver_output.image, actual_driver_output.image, tolerance=0)
if diff_result[0]:
failures.append(test_failures.FailureReftestMismatch(reference_filename))
else:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
