[webkit-changes] [126358] trunk/LayoutTests

Wed, 22 Aug 2012 15:22:41 -0700

Title: [126358] trunk/LayoutTests
Revision
126358
Author
[email protected]
Date
2012-08-22 15:23:12 -0700 (Wed, 22 Aug 2012)

Log Message

Test cases under fast/filesystem/workers are flaky when using JSC
https://bugs.webkit.org/show_bug.cgi?id=94747

Patch by Leo Yang <[email protected]> on 2012-08-22
Reviewed by Yong Li.

These test cases sometimes can't complete because the worker object
created by startWorker() has been gc'ed before the worker thread complete.
We should reference the object to avoid it being gc'ed.

* fast/filesystem/workers/async-operations.html:
* fast/filesystem/workers/file-entry-to-uri-sync.html:
* fast/filesystem/workers/file-from-file-entry-sync.html:
* fast/filesystem/workers/file-from-file-entry.html:
* fast/filesystem/workers/file-writer-empty-blob.html:
* fast/filesystem/workers/file-writer-events.html:
* fast/filesystem/workers/file-writer-gc-blob.html:
* fast/filesystem/workers/file-writer-sync-truncate-extend.html:
* fast/filesystem/workers/file-writer-sync-write-overlapped.html:
* fast/filesystem/workers/file-writer-truncate-extend.html:
* fast/filesystem/workers/file-writer-write-overlapped.html:
* fast/filesystem/workers/simple-persistent-sync.html:
* fast/filesystem/workers/simple-persistent.html:
* fast/filesystem/workers/simple-temporary-sync.html:
* fast/filesystem/workers/simple-temporary.html:
* fast/filesystem/workers/sync-operations.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (126357 => 126358)


--- trunk/LayoutTests/ChangeLog	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/ChangeLog	2012-08-22 22:23:12 UTC (rev 126358)
@@ -1,3 +1,31 @@
+2012-08-22  Leo Yang  <[email protected]>
+
+        Test cases under fast/filesystem/workers are flaky when using JSC
+        https://bugs.webkit.org/show_bug.cgi?id=94747
+
+        Reviewed by Yong Li.
+
+        These test cases sometimes can't complete because the worker object
+        created by startWorker() has been gc'ed before the worker thread complete.
+        We should reference the object to avoid it being gc'ed.
+
+        * fast/filesystem/workers/async-operations.html:
+        * fast/filesystem/workers/file-entry-to-uri-sync.html:
+        * fast/filesystem/workers/file-from-file-entry-sync.html:
+        * fast/filesystem/workers/file-from-file-entry.html:
+        * fast/filesystem/workers/file-writer-empty-blob.html:
+        * fast/filesystem/workers/file-writer-events.html:
+        * fast/filesystem/workers/file-writer-gc-blob.html:
+        * fast/filesystem/workers/file-writer-sync-truncate-extend.html:
+        * fast/filesystem/workers/file-writer-sync-write-overlapped.html:
+        * fast/filesystem/workers/file-writer-truncate-extend.html:
+        * fast/filesystem/workers/file-writer-write-overlapped.html:
+        * fast/filesystem/workers/simple-persistent-sync.html:
+        * fast/filesystem/workers/simple-persistent.html:
+        * fast/filesystem/workers/simple-temporary-sync.html:
+        * fast/filesystem/workers/simple-temporary.html:
+        * fast/filesystem/workers/sync-operations.html:
+
 2012-08-22  Anna Cavender  <[email protected]>
 
         Update the TextTrackCue Constructor

Modified: trunk/LayoutTests/fast/filesystem/workers/async-operations.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/async-operations.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/async-operations.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/async-operations.js');
+worker = startWorker('../resources/async-operations.js');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-entry-to-uri-sync.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-entry-to-uri-sync.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-entry-to-uri-sync.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/file-entry-to-uri-sync.js');
+worker = startWorker('../resources/file-entry-to-uri-sync.js');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-from-file-entry-sync.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-from-file-entry-sync.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-from-file-entry-sync.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/file-from-file-entry-sync.js');
+worker = startWorker('../resources/file-from-file-entry-sync.js');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-from-file-entry.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-from-file-entry.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-from-file-entry.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/file-from-file-entry.js');
+worker = startWorker('../resources/file-from-file-entry.js');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-writer-empty-blob.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-writer-empty-blob.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-writer-empty-blob.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -8,7 +8,7 @@
 <div id="description"></div>
 <div id="console"></div>
 <script>
-startWorker("../resources/file-writer-empty-blob.js");
+worker = startWorker("../resources/file-writer-empty-blob.js");
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-writer-events.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-writer-events.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-writer-events.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-events.js");
+        worker = startWorker("../resources/file-writer-events.js");
     </script>
     <script src=""
  </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-writer-gc-blob.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-writer-gc-blob.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-writer-gc-blob.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-gc-blob.js");
+        worker = startWorker("../resources/file-writer-gc-blob.js");
     </script>
     <script src=""
  </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-writer-sync-truncate-extend.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-writer-sync-truncate-extend.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-writer-sync-truncate-extend.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-sync-truncate-extend.js");
+        worker = startWorker("../resources/file-writer-sync-truncate-extend.js");
     </script>
     <script src=""
  </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-writer-sync-write-overlapped.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-writer-sync-write-overlapped.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-writer-sync-write-overlapped.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-sync-write-overlapped.js");
+        worker = startWorker("../resources/file-writer-sync-write-overlapped.js");
     </script>
     <script src=""
  </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-writer-truncate-extend.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-writer-truncate-extend.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-writer-truncate-extend.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-truncate-extend.js");
+        worker = startWorker("../resources/file-writer-truncate-extend.js");
     </script>
     <script src=""
  </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/file-writer-write-overlapped.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/file-writer-write-overlapped.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/file-writer-write-overlapped.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-write-overlapped.js");
+        worker = startWorker("../resources/file-writer-write-overlapped.js");
     </script>
     <script src=""
  </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/simple-persistent-sync.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/simple-persistent-sync.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/simple-persistent-sync.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/simple-persistent-sync.js');
+worker = startWorker('../resources/simple-persistent-sync.js');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/simple-persistent.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/simple-persistent.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/simple-persistent.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/simple-persistent.js');
+worker = startWorker('../resources/simple-persistent.js');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/simple-temporary-sync.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/simple-temporary-sync.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/simple-temporary-sync.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/simple-temporary-sync.js');
+worker = startWorker('../resources/simple-temporary-sync.js');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/simple-temporary.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/simple-temporary.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/simple-temporary.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/simple-temporary.js');
+worker = startWorker('../resources/simple-temporary.js');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/filesystem/workers/sync-operations.html (126357 => 126358)


--- trunk/LayoutTests/fast/filesystem/workers/sync-operations.html	2012-08-22 22:01:55 UTC (rev 126357)
+++ trunk/LayoutTests/fast/filesystem/workers/sync-operations.html	2012-08-22 22:23:12 UTC (rev 126358)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/sync-operations.js');
+worker = startWorker('../resources/sync-operations.js');
 </script>
 <script src=""
 </body>

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to