Title: [126784] trunk/Tools
- Revision
- 126784
- Author
- [email protected]
- Date
- 2012-08-27 12:16:22 -0700 (Mon, 27 Aug 2012)
Log Message
[chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
https://bugs.webkit.org/show_bug.cgi?id=95115
Reviewed by Adam Barth.
Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
code if the unit tests crash.
* Scripts/run-chromium-webkit-unit-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (126783 => 126784)
--- trunk/Tools/ChangeLog 2012-08-27 19:06:54 UTC (rev 126783)
+++ trunk/Tools/ChangeLog 2012-08-27 19:16:22 UTC (rev 126784)
@@ -1,3 +1,15 @@
+2012-08-27 James Robinson <[email protected]>
+
+ [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
+ https://bugs.webkit.org/show_bug.cgi?id=95115
+
+ Reviewed by Adam Barth.
+
+ Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
+ code if the unit tests crash.
+
+ * Scripts/run-chromium-webkit-unit-tests:
+
2012-08-27 Benjamin Poulain <[email protected]>
Add ECMAScript Number to String conversion to WTF::String
Modified: trunk/Tools/Scripts/run-chromium-webkit-unit-tests (126783 => 126784)
--- trunk/Tools/Scripts/run-chromium-webkit-unit-tests 2012-08-27 19:06:54 UTC (rev 126783)
+++ trunk/Tools/Scripts/run-chromium-webkit-unit-tests 2012-08-27 19:16:22 UTC (rev 126784)
@@ -32,9 +32,9 @@
use FindBin;
use lib $FindBin::Bin;
use webkitdirs;
+use VCSUtils;
push(@ARGV, "--chromium");
setConfiguration();
my $pathToBinary = productDir() . "/webkit_unit_tests";
-# perl's "system" function's return value has to be right shifted by 8 to get the program's exit code.
-exit system ($pathToBinary, @ARGV) >> 8;
+exit exitStatus(system ($pathToBinary, @ARGV));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
