Title: [127050] trunk/LayoutTests
Revision
127050
Author
t...@chromium.org
Date
2012-08-29 14:23:50 -0700 (Wed, 29 Aug 2012)

Log Message

r126257 broke css3/flexbox/flexitem.html
https://bugs.webkit.org/show_bug.cgi?id=94720

Reviewed by Ojan Vafai.

Move the failing test case into a new file so we can re-enable the
rest of the tests. We probably need to add some debugging information
to the failing test case to identify the cause of flakiness.

* css3/flexbox/flexitem-expected.txt: Remove flaky test case.
* css3/flexbox/flexitem-stretch-image-expected.txt: Added.
* css3/flexbox/flexitem-stretch-image.html: Added.
* css3/flexbox/flexitem.html: Remove flaky test case.
* platform/chromium/TestExpectations: Change failure to new test.
* platform/efl/TestExpectations: Change failure to new test.
* platform/mac/Skipped: Remove so we can get flakiness information.
* platform/mac/TestExpectations: Mark new test as flaky.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (127049 => 127050)


--- trunk/LayoutTests/ChangeLog	2012-08-29 21:17:21 UTC (rev 127049)
+++ trunk/LayoutTests/ChangeLog	2012-08-29 21:23:50 UTC (rev 127050)
@@ -1,3 +1,23 @@
+2012-08-29  Tony Chang  <t...@chromium.org>
+
+        r126257 broke css3/flexbox/flexitem.html
+        https://bugs.webkit.org/show_bug.cgi?id=94720
+
+        Reviewed by Ojan Vafai.
+
+        Move the failing test case into a new file so we can re-enable the
+        rest of the tests. We probably need to add some debugging information
+        to the failing test case to identify the cause of flakiness.
+
+        * css3/flexbox/flexitem-expected.txt: Remove flaky test case.
+        * css3/flexbox/flexitem-stretch-image-expected.txt: Added.
+        * css3/flexbox/flexitem-stretch-image.html: Added.
+        * css3/flexbox/flexitem.html: Remove flaky test case.
+        * platform/chromium/TestExpectations: Change failure to new test.
+        * platform/efl/TestExpectations: Change failure to new test.
+        * platform/mac/Skipped: Remove so we can get flakiness information.
+        * platform/mac/TestExpectations: Mark new test as flaky.
+
 2012-08-29  David Grogan  <dgro...@chromium.org>
 
         IndexedDB: Throw TypeError for invalid version parameters

Modified: trunk/LayoutTests/css3/flexbox/flexitem-expected.txt (127049 => 127050)


--- trunk/LayoutTests/css3/flexbox/flexitem-expected.txt	2012-08-29 21:17:21 UTC (rev 127049)
+++ trunk/LayoutTests/css3/flexbox/flexitem-expected.txt	2012-08-29 21:23:50 UTC (rev 127050)
@@ -7,9 +7,7 @@
 PASS
 
 PASS
-
 PASS
-PASS
 button
 PASS
 PASS

Added: trunk/LayoutTests/css3/flexbox/flexitem-stretch-image-expected.txt (0 => 127050)


--- trunk/LayoutTests/css3/flexbox/flexitem-stretch-image-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/css3/flexbox/flexitem-stretch-image-expected.txt	2012-08-29 21:23:50 UTC (rev 127050)
@@ -0,0 +1,2 @@
+
+PASS
Property changes on: trunk/LayoutTests/css3/flexbox/flexitem-stretch-image-expected.txt
___________________________________________________________________

Added: svn:eol-style

Added: trunk/LayoutTests/css3/flexbox/flexitem-stretch-image.html (0 => 127050)


--- trunk/LayoutTests/css3/flexbox/flexitem-stretch-image.html	                        (rev 0)
+++ trunk/LayoutTests/css3/flexbox/flexitem-stretch-image.html	2012-08-29 21:23:50 UTC (rev 127050)
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<html>
+<style>
+.flexbox {
+    width: 600px;
+    display: -webkit-flex;
+    background-color: #aaa;
+    position: relative;
+    min-height: 10px;
+}
+.flexbox > * {
+    margin: 0;
+    border: 0;
+    padding: 0;
+    min-width: 0;
+}
+</style>
+<script>
+if (window.testRunner)
+    testRunner.dumpAsText();
+</script>
+<script src=""
+<body _onload_="checkLayout('.flexbox')">
+
+<div class="flexbox">
+  <img data-expected-display="block" data-expected-width="345" style="-webkit-flex: 1 0 auto;" src=""
+  <img data-expected-display="block" data-expected-width="255" data-expected-height="100" style="-webkit-flex: 1 0 auto;" src=""
+</div>
+
+</body>
Property changes on: trunk/LayoutTests/css3/flexbox/flexitem-stretch-image.html
___________________________________________________________________

Added: svn:eol-style

Modified: trunk/LayoutTests/css3/flexbox/flexitem.html (127049 => 127050)


--- trunk/LayoutTests/css3/flexbox/flexitem.html	2012-08-29 21:17:21 UTC (rev 127049)
+++ trunk/LayoutTests/css3/flexbox/flexitem.html	2012-08-29 21:23:50 UTC (rev 127050)
@@ -50,11 +50,6 @@
 </div>
 
 <div class="flexbox">
-  <img data-expected-display="block" data-expected-width="345" style="-webkit-flex: 1 0 auto;" src=""
-  <img data-expected-display="block" data-expected-width="255" data-expected-height="100" style="-webkit-flex: 1 0 auto;" src=""
-</div>
-
-<div class="flexbox">
   <img data-expected-display="block" data-expected-width="200" style="-webkit-flex: 1 0 auto;" src=""
   <img data-expected-display="block" data-expected-width="200" data-expected-height="100" style="-webkit-flex: 2 0 0;" src=""
   <img data-expected-display="block" data-expected-width="200" data-expected-height="100" style="-webkit-flex: 2 0 0;" src="" alt="placeholder text">

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127049 => 127050)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-08-29 21:17:21 UTC (rev 127049)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-08-29 21:23:50 UTC (rev 127050)
@@ -3480,7 +3480,7 @@
 BUGWK94532 LINUX : fast/forms/formmethod-attribute-button-html.html = PASS MISSING
 
 BUGWK94660 : fast/js/create-lots-of-workers.html = PASS CRASH TIMEOUT
-BUGWK94675 : css3/flexbox/flexitem.html = TEXT
+BUGWK95366 DEBUG : css3/flexbox/flexitem-stretch-image.html = TEXT
 
 BUGWK94730 MAC : fast/repaint/japanese-rl-selection-repaint-in-regions.html = IMAGE
 

Modified: trunk/LayoutTests/platform/efl/TestExpectations (127049 => 127050)


--- trunk/LayoutTests/platform/efl/TestExpectations	2012-08-29 21:17:21 UTC (rev 127049)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-08-29 21:23:50 UTC (rev 127050)
@@ -855,7 +855,7 @@
 BUGWK88031 : fast/multicol/span/generated-child-split-flow-crash.html = TEXT
 
 // Flexbox test failing on EFL.
-BUGWK88984 : css3/flexbox/flexitem.html = TEXT
+BUGWK95366 : css3/flexbox/flexitem-stretch-image.html = TEXT
 
 // New test introduced in r122663 failing on GTK and Qt as well
 BUGWK91339 : css2.1/20110323/vertical-align-boxes-001.htm = IMAGE

Modified: trunk/LayoutTests/platform/mac/Skipped (127049 => 127050)


--- trunk/LayoutTests/platform/mac/Skipped	2012-08-29 21:17:21 UTC (rev 127049)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-08-29 21:23:50 UTC (rev 127050)
@@ -961,9 +961,6 @@
 # ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) is disabled
 fast/forms/time-multiple-fields
 
-# https://bugs.webkit.org/show_bug.cgi?id=94720
-css3/flexbox/flexitem.html
-
 # <rdar://problem/11224160> Focus not transferring properly in DumpRenderTree in Mountain Lion
 fast/events/show-modal-dialog-onblur-onfocus.html
 platform/mac/fast/forms/listbox-scrollbar-hit-test.html

Modified: trunk/LayoutTests/platform/mac/TestExpectations (127049 => 127050)


--- trunk/LayoutTests/platform/mac/TestExpectations	2012-08-29 21:17:21 UTC (rev 127049)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2012-08-29 21:23:50 UTC (rev 127050)
@@ -354,6 +354,9 @@
 BUGWK93560 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551.html = PASS TEXT
 BUGWK93560 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html = PASS TEXT
 
+// Flexbox test failing on Mac.
+BUGWK95366 : css3/flexbox/flexitem-stretch-image.html = TEXT
+
 //Require rebaseline after https://bugs.webkit.org/show_bug.cgi?id=77754
 BUGWK77754 : fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html = TEXT
 BUGWK77754 : fast/inline/absolute-positioned-inline-in-centred-block.html = TEXT
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to