Diff
Modified: trunk/LayoutTests/ChangeLog (127227 => 127228)
--- trunk/LayoutTests/ChangeLog 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/LayoutTests/ChangeLog 2012-08-31 04:27:31 UTC (rev 127228)
@@ -1,3 +1,13 @@
+2012-08-30 MORITA Hajime <morr...@google.com>
+
+ Unreviewed, rolling out r126127.
+ http://trac.webkit.org/changeset/126127
+
+ This breaks gobject bindings.
+
+ * fast/dom/shadow/shadowroot-clonenode-expected.txt: Removed.
+ * fast/dom/shadow/shadowroot-clonenode.html: Removed.
+
2012-08-30 Yoshifumi Inoue <yo...@chromium.org>
[Forms] Shift+Tab should focus the last field of multiple fields time input UI
Deleted: trunk/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt (127227 => 127228)
--- trunk/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt 2012-08-31 04:27:31 UTC (rev 127228)
@@ -1,10 +0,0 @@
-Calling ShadowRoot.cloneNode() should throw a DATA_CLONE_ERR exception.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS exceptionCode is DOMException.DATA_CLONE_ERR
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/dom/shadow/shadowroot-clonenode.html (127227 => 127228)
--- trunk/LayoutTests/fast/dom/shadow/shadowroot-clonenode.html 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/LayoutTests/fast/dom/shadow/shadowroot-clonenode.html 2012-08-31 04:27:31 UTC (rev 127228)
@@ -1,26 +0,0 @@
-<!DOCTYPE>
-<html>
-<script src=""
-<script src=""
-
-<pre id="console"></pre>
-
-<script>
-description('Calling ShadowRoot.cloneNode() should throw a DATA_CLONE_ERR exception.');
-
-var host = document.createElement('div');
-var shadowRoot = new WebKitShadowRoot(host);
-
-var exceptionCode = null;
-try {
- shadowRoot.cloneNode()
-} catch (e) {
- exceptionCode = e.code;
-}
-
-shouldBe('exceptionCode', 'DOMException.DATA_CLONE_ERR')
-
-finishJSTest();
-</script>
-<script src=""
-</html>
Modified: trunk/Source/WebCore/ChangeLog (127227 => 127228)
--- trunk/Source/WebCore/ChangeLog 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/ChangeLog 2012-08-31 04:27:31 UTC (rev 127228)
@@ -1,3 +1,57 @@
+2012-08-30 MORITA Hajime <morr...@google.com>
+
+ Unreviewed, rolling out r126127.
+ http://trac.webkit.org/changeset/126127
+
+ This breaks gobject bindings.
+
+ * dom/Attr.cpp:
+ (WebCore::Attr::cloneNode):
+ * dom/Attr.h:
+ * dom/CDATASection.cpp:
+ (WebCore::CDATASection::cloneNode):
+ * dom/CDATASection.h:
+ (CDATASection):
+ * dom/Comment.cpp:
+ (WebCore::Comment::cloneNode):
+ * dom/Comment.h:
+ (Comment):
+ * dom/Document.cpp:
+ (WebCore::Document::cloneNode):
+ * dom/Document.h:
+ (Document):
+ * dom/DocumentFragment.cpp:
+ (WebCore::DocumentFragment::cloneNode):
+ * dom/DocumentFragment.h:
+ (DocumentFragment):
+ * dom/DocumentType.cpp:
+ (WebCore::DocumentType::cloneNode):
+ * dom/DocumentType.h:
+ (DocumentType):
+ * dom/Element.cpp:
+ (WebCore::Element::cloneNode):
+ * dom/Element.h:
+ (Element):
+ * dom/EntityReference.cpp:
+ (WebCore::EntityReference::cloneNode):
+ * dom/EntityReference.h:
+ (EntityReference):
+ * dom/Node.h:
+ (Node):
+ * dom/Node.idl:
+ * dom/ProcessingInstruction.cpp:
+ (WebCore::ProcessingInstruction::cloneNode):
+ * dom/ProcessingInstruction.h:
+ (ProcessingInstruction):
+ * dom/ShadowRoot.cpp:
+ (WebCore::ShadowRoot::cloneNode):
+ * dom/ShadowRoot.h:
+ (ShadowRoot):
+ * dom/Text.cpp:
+ (WebCore::Text::cloneNode):
+ * dom/Text.h:
+ (Text):
+
2012-08-30 Adam Barth <aba...@webkit.org>
Loading a worker script should not be O(n^2)
Modified: trunk/Source/WebCore/dom/Attr.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/Attr.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Attr.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -138,7 +138,7 @@
setValue(v, ec);
}
-PassRefPtr<Node> Attr::cloneNode(bool /*deep*/, ExceptionCode&)
+PassRefPtr<Node> Attr::cloneNode(bool /*deep*/)
{
RefPtr<Attr> clone = adoptRef(new Attr(document(), qualifiedName(), value()));
cloneChildNodes(clone.get());
Modified: trunk/Source/WebCore/dom/Attr.h (127227 => 127228)
--- trunk/Source/WebCore/dom/Attr.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Attr.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -81,7 +81,7 @@
virtual String nodeValue() const OVERRIDE { return value(); }
virtual void setNodeValue(const String&, ExceptionCode&);
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual bool isAttributeNode() const { return true; }
virtual bool childTypeAllowed(NodeType) const;
Modified: trunk/Source/WebCore/dom/CDATASection.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/CDATASection.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/CDATASection.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -46,7 +46,7 @@
return CDATA_SECTION_NODE;
}
-PassRefPtr<Node> CDATASection::cloneNode(bool /*deep*/, ExceptionCode&)
+PassRefPtr<Node> CDATASection::cloneNode(bool /*deep*/)
{
return create(document(), data());
}
Modified: trunk/Source/WebCore/dom/CDATASection.h (127227 => 127228)
--- trunk/Source/WebCore/dom/CDATASection.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/CDATASection.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -36,7 +36,7 @@
virtual String nodeName() const;
virtual NodeType nodeType() const;
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual bool childTypeAllowed(NodeType) const;
virtual PassRefPtr<Text> virtualCreate(const String&);
};
Modified: trunk/Source/WebCore/dom/Comment.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/Comment.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Comment.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -46,7 +46,7 @@
return COMMENT_NODE;
}
-PassRefPtr<Node> Comment::cloneNode(bool /*deep*/, ExceptionCode&)
+PassRefPtr<Node> Comment::cloneNode(bool /*deep*/)
{
return create(document(), data());
}
Modified: trunk/Source/WebCore/dom/Comment.h (127227 => 127228)
--- trunk/Source/WebCore/dom/Comment.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Comment.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -36,7 +36,7 @@
virtual String nodeName() const;
virtual NodeType nodeType() const;
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual bool childTypeAllowed(NodeType) const;
};
Modified: trunk/Source/WebCore/dom/Document.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/Document.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Document.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -3296,7 +3296,7 @@
return true;
}
-PassRefPtr<Node> Document::cloneNode(bool /*deep*/, ExceptionCode&)
+PassRefPtr<Node> Document::cloneNode(bool /*deep*/)
{
// Spec says cloning Document nodes is "implementation dependent"
// so we do not support it...
Modified: trunk/Source/WebCore/dom/Document.h (127227 => 127228)
--- trunk/Source/WebCore/dom/Document.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Document.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -1208,7 +1208,7 @@
virtual String nodeName() const;
virtual NodeType nodeType() const;
virtual bool childTypeAllowed(NodeType) const;
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual bool canReplaceChild(Node* newChild, Node* oldChild);
virtual void refScriptExecutionContext() { ref(); }
Modified: trunk/Source/WebCore/dom/DocumentFragment.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/DocumentFragment.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/DocumentFragment.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -68,7 +68,7 @@
}
}
-PassRefPtr<Node> DocumentFragment::cloneNode(bool deep, ExceptionCode&)
+PassRefPtr<Node> DocumentFragment::cloneNode(bool deep)
{
RefPtr<DocumentFragment> clone = create(document());
if (deep)
Modified: trunk/Source/WebCore/dom/DocumentFragment.h (127227 => 127228)
--- trunk/Source/WebCore/dom/DocumentFragment.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/DocumentFragment.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -44,7 +44,7 @@
private:
virtual NodeType nodeType() const;
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual bool childTypeAllowed(NodeType) const;
};
Modified: trunk/Source/WebCore/dom/DocumentType.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/DocumentType.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/DocumentType.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -51,7 +51,7 @@
return DOCUMENT_TYPE_NODE;
}
-PassRefPtr<Node> DocumentType::cloneNode(bool /*deep*/, ExceptionCode&)
+PassRefPtr<Node> DocumentType::cloneNode(bool /*deep*/)
{
return create(document(), m_name, m_publicId, m_systemId);
}
Modified: trunk/Source/WebCore/dom/DocumentType.h (127227 => 127228)
--- trunk/Source/WebCore/dom/DocumentType.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/DocumentType.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -52,7 +52,7 @@
virtual KURL baseURI() const;
virtual String nodeName() const;
virtual NodeType nodeType() const;
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
virtual void removedFrom(ContainerNode*) OVERRIDE;
Modified: trunk/Source/WebCore/dom/Element.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/Element.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Element.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -170,7 +170,7 @@
DEFINE_VIRTUAL_ATTRIBUTE_EVENT_LISTENER(Element, focus);
DEFINE_VIRTUAL_ATTRIBUTE_EVENT_LISTENER(Element, load);
-PassRefPtr<Node> Element::cloneNode(bool deep, ExceptionCode&)
+PassRefPtr<Node> Element::cloneNode(bool deep)
{
return deep ? cloneElementWithChildren() : cloneElementWithoutChildren();
}
Modified: trunk/Source/WebCore/dom/Element.h (127227 => 127228)
--- trunk/Source/WebCore/dom/Element.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Element.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -500,7 +500,7 @@
// cloneNode is private so that non-virtual cloneElementWithChildren and cloneElementWithoutChildren
// are used instead.
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual PassRefPtr<Element> cloneElementWithoutAttributesAndChildren();
QualifiedName m_tagName;
Modified: trunk/Source/WebCore/dom/EntityReference.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/EntityReference.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/EntityReference.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -46,7 +46,7 @@
return ENTITY_REFERENCE_NODE;
}
-PassRefPtr<Node> EntityReference::cloneNode(bool, ExceptionCode&)
+PassRefPtr<Node> EntityReference::cloneNode(bool)
{
return create(document(), m_entityName);
}
Modified: trunk/Source/WebCore/dom/EntityReference.h (127227 => 127228)
--- trunk/Source/WebCore/dom/EntityReference.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/EntityReference.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -35,7 +35,7 @@
virtual String nodeName() const;
virtual NodeType nodeType() const;
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
String m_entityName;
};
Modified: trunk/Source/WebCore/dom/Node.h (127227 => 127228)
--- trunk/Source/WebCore/dom/Node.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Node.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -27,7 +27,6 @@
#include "EditingBoundary.h"
#include "EventTarget.h"
-#include "ExceptionCodePlaceholder.h"
#include "FractionalLayoutRect.h"
#include "KURLHash.h"
#include "LayoutTypes.h"
@@ -188,8 +187,7 @@
void remove(ExceptionCode&);
bool hasChildNodes() const { return firstChild(); }
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&) = 0;
- PassRefPtr<Node> cloneNode(bool deep) { return cloneNode(deep, ASSERT_NO_EXCEPTION); }
+ virtual PassRefPtr<Node> cloneNode(bool deep) = 0;
const AtomicString& localName() const { return virtualLocalName(); }
const AtomicString& namespaceURI() const { return virtualNamespaceURI(); }
const AtomicString& prefix() const { return virtualPrefix(); }
Modified: trunk/Source/WebCore/dom/Node.idl (127227 => 127228)
--- trunk/Source/WebCore/dom/Node.idl 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Node.idl 2012-08-31 04:27:31 UTC (rev 127228)
@@ -79,9 +79,7 @@
raises(DOMException);
boolean hasChildNodes();
- Node cloneNode(in [Optional=DefaultIsUndefined] boolean deep)
- raises(DOMException);
-
+ Node cloneNode(in [Optional=DefaultIsUndefined] boolean deep);
void normalize();
// Introduced in DOM Level 2:
Modified: trunk/Source/WebCore/dom/ProcessingInstruction.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/ProcessingInstruction.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/ProcessingInstruction.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -97,7 +97,7 @@
setData(nodeValue, ec);
}
-PassRefPtr<Node> ProcessingInstruction::cloneNode(bool /*deep*/, ExceptionCode&)
+PassRefPtr<Node> ProcessingInstruction::cloneNode(bool /*deep*/)
{
// FIXME: Is it a problem that this does not copy m_localHref?
// What about other data members?
Modified: trunk/Source/WebCore/dom/ProcessingInstruction.h (127227 => 127228)
--- trunk/Source/WebCore/dom/ProcessingInstruction.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/ProcessingInstruction.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -60,7 +60,7 @@
virtual NodeType nodeType() const;
virtual String nodeValue() const;
virtual void setNodeValue(const String&, ExceptionCode&);
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual bool offsetInCharacters() const;
virtual int maxCharacterOffset() const;
Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -139,10 +139,9 @@
return "#shadow-root";
}
-PassRefPtr<Node> ShadowRoot::cloneNode(bool, ExceptionCode& ec)
+PassRefPtr<Node> ShadowRoot::cloneNode(bool)
{
// ShadowRoot should not be arbitrarily cloned.
- ec = DATA_CLONE_ERR;
return 0;
}
Modified: trunk/Source/WebCore/dom/ShadowRoot.h (127227 => 127228)
--- trunk/Source/WebCore/dom/ShadowRoot.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/ShadowRoot.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -97,7 +97,7 @@
explicit ShadowRoot(Document*);
virtual ~ShadowRoot();
virtual String nodeName() const;
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual bool childTypeAllowed(NodeType) const;
virtual void childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta) OVERRIDE;
Modified: trunk/Source/WebCore/dom/Text.cpp (127227 => 127228)
--- trunk/Source/WebCore/dom/Text.cpp 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Text.cpp 2012-08-31 04:27:31 UTC (rev 127228)
@@ -185,7 +185,7 @@
return TEXT_NODE;
}
-PassRefPtr<Node> Text::cloneNode(bool /*deep*/, ExceptionCode&)
+PassRefPtr<Node> Text::cloneNode(bool /*deep*/)
{
return create(document(), data());
}
Modified: trunk/Source/WebCore/dom/Text.h (127227 => 127228)
--- trunk/Source/WebCore/dom/Text.h 2012-08-31 04:00:54 UTC (rev 127227)
+++ trunk/Source/WebCore/dom/Text.h 2012-08-31 04:27:31 UTC (rev 127228)
@@ -58,7 +58,7 @@
private:
virtual String nodeName() const;
virtual NodeType nodeType() const;
- virtual PassRefPtr<Node> cloneNode(bool deep, ExceptionCode&);
+ virtual PassRefPtr<Node> cloneNode(bool deep);
virtual bool rendererIsNeeded(const NodeRenderingContext&);
virtual RenderObject* createRenderer(RenderArena*, RenderStyle*);
virtual bool childTypeAllowed(NodeType) const;
