[webkit-changes] [127486] trunk/Source/WebKit/blackberry

[rwlbuis]

Title: [127486] trunk/Source/WebKit/blackberry

Revision

127486

Author

rwlb...@webkit.org

Date

2012-09-04 12:46:35 -0700 (Tue, 04 Sep 2012)

Log Message

[BlackBerry] Provide virtual dtor for DumpRenderTreeClient
https://bugs.webkit.org/show_bug.cgi?id=95769

Reviewed by NOBODY (OOPS!).

Also remove WTF prefixes.

* Api/DumpRenderTreeClient.h:

Modified Paths

• trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h
• trunk/Source/WebKit/blackberry/ChangeLog

Diff

Modified: trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h (127485 => 127486)

--- trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h	2012-09-04 19:43:51 UTC (rev 127485)
+++ trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h	2012-09-04 19:46:35 UTC (rev 127486)
@@ -42,6 +42,7 @@
 
 class BLACKBERRY_EXPORT DumpRenderTreeClient {
 public:
+    virtual ~DumpRenderTreeClient() { }
     virtual void runTests() = 0;
 
     // FrameLoaderClient delegates
@@ -53,19 +54,19 @@
     virtual void didFinishLoadForFrame(WebCore::Frame*) = 0;
     virtual void didFinishDocumentLoadForFrame(WebCore::Frame*) = 0;
     virtual void didClearWindowObjectInWorld(WebCore::DOMWrapperWorld*, JSGlobalContextRef, JSObjectRef windowObject) = 0;
-    virtual void didReceiveTitleForFrame(const WTF::String& title, WebCore::Frame*) = 0;
+    virtual void didReceiveTitleForFrame(const String& title, WebCore::Frame*) = 0;
     virtual void didDecidePolicyForNavigationAction(const WebCore::NavigationAction&, const WebCore::ResourceRequest&) = 0;
     virtual void didDispatchWillPerformClientRedirect() = 0;
     virtual void didHandleOnloadEventsForFrame(WebCore::Frame*) = 0;
 
     // ChromeClient delegates
-    virtual void addMessageToConsole(const WTF::String& message, unsigned int lineNumber, const WTF::String& sourceID) = 0;
-    virtual void runJavaScriptAlert(const WTF::String& message) = 0;
-    virtual bool runJavaScriptConfirm(const WTF::String& message) = 0;
-    virtual WTF::String runJavaScriptPrompt(const WTF::String& message, const WTF::String& defaultValue) = 0;
-    virtual bool runBeforeUnloadConfirmPanel(const WTF::String& message) = 0;
-    virtual void setStatusText(const WTF::String&) = 0;
-    virtual void exceededDatabaseQuota(WebCore::SecurityOrigin*, const WTF::String& name) = 0;
+    virtual void addMessageToConsole(const String& message, unsigned int lineNumber, const String& sourceID) = 0;
+    virtual void runJavaScriptAlert(const String& message) = 0;
+    virtual bool runJavaScriptConfirm(const String& message) = 0;
+    virtual String runJavaScriptPrompt(const String& message, const String& defaultValue) = 0;
+    virtual bool runBeforeUnloadConfirmPanel(const String& message) = 0;
+    virtual void setStatusText(const String&) = 0;
+    virtual void exceededDatabaseQuota(WebCore::SecurityOrigin*, const String& name) = 0;
     virtual bool allowsOpeningWindow() = 0;
     virtual void windowCreated(WebPage*) = 0;
 
@@ -80,7 +81,7 @@
     virtual bool shouldDeleteDOMRange(WebCore::Range*) = 0;
     virtual bool shouldChangeSelectedDOMRangeToDOMRangeAffinityStillSelecting(WebCore::Range* fromRange, WebCore::Range* toRange, int affinity, bool stillSelecting) = 0;
     virtual bool shouldInsertNode(WebCore::Node*, WebCore::Range*, int insertAction) = 0;
-    virtual bool shouldInsertText(const WTF::String&, WebCore::Range*, int insertAction) = 0;
+    virtual bool shouldInsertText(const String&, WebCore::Range*, int insertAction) = 0;
     virtual bool isSelectTrailingWhitespaceEnabled() const = 0;
     virtual bool didReceiveAuthenticationChallenge(WebCore::Credential&) = 0;
 

Modified: trunk/Source/WebKit/blackberry/ChangeLog (127485 => 127486)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-04 19:43:51 UTC (rev 127485)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-04 19:46:35 UTC (rev 127486)
@@ -1,3 +1,14 @@
+2012-09-04  Rob Buis  <rb...@rim.com>
+
+        [BlackBerry] Provide virtual dtor for DumpRenderTreeClient
+        https://bugs.webkit.org/show_bug.cgi?id=95769
+
+        Reviewed by Yong Li.
+
+        Also remove WTF prefixes.
+
+        * Api/DumpRenderTreeClient.h:
+
 2012-09-04  Mary Wu  <mary...@torchmobile.com.cn>
 
         [BlackBerry] Add webplatform and browser to build info

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes