Title: [127582] trunk
Revision
127582
Author
commit-qu...@webkit.org
Date
2012-09-05 06:06:01 -0700 (Wed, 05 Sep 2012)

Log Message

[EFL][WK2] Provide implementation for WebFrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=95826

Patch by Christophe Dumez <christophe.du...@intel.com> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Remove EFL-specific and empty implementation for WebFrameNetworkingContext
and use the existing soup implementation instead.

* PlatformEfl.cmake:
* WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Removed.

LayoutTests:

Unskip several cookie-related test cases for WK2 EFL
now that WebFrameNetworkingContext is implemented.

* platform/efl-wk2/TestExpectations:

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (127581 => 127582)


--- trunk/LayoutTests/ChangeLog	2012-09-05 12:34:58 UTC (rev 127581)
+++ trunk/LayoutTests/ChangeLog	2012-09-05 13:06:01 UTC (rev 127582)
@@ -1,3 +1,15 @@
+2012-09-05  Christophe Dumez  <christophe.du...@intel.com>
+
+        [EFL][WK2] Provide implementation for WebFrameNetworkingContext
+        https://bugs.webkit.org/show_bug.cgi?id=95826
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Unskip several cookie-related test cases for WK2 EFL
+        now that WebFrameNetworkingContext is implemented.
+
+        * platform/efl-wk2/TestExpectations:
+
 2012-09-05  MORITA Hajime  <morr...@google.com>
 
         ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.

Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (127581 => 127582)


--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-05 12:34:58 UTC (rev 127581)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-05 13:06:01 UTC (rev 127582)
@@ -203,22 +203,6 @@
 BUGWKEFL : fast/ruby/rubyDOM-remove-text1.html = TEXT
 BUGWKEFL : fast/ruby/rubyDOM-remove-text2.html = TEXT
 
-// Failing Security tests
-BUGWKEFL : http/tests/security/aboutBlank/security-context-grandchildren-lexical.html = TEXT
-BUGWKEFL : http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html = TEXT
-BUGWKEFL : http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html = TEXT
-BUGWKEFL : http/tests/security/aboutBlank/security-context-grandchildren.html = TEXT
-BUGWKEFL : http/tests/security/aboutBlank/security-context-window-open.html = TEXT
-BUGWKEFL : http/tests/security/aboutBlank/security-context-with-base-tag.html = TEXT
-BUGWKEFL : http/tests/security/aboutBlank/security-context-write.html = TEXT
-BUGWKEFL : http/tests/security/aboutBlank/security-context-writeln.html = TEXT
-BUGWKEFL : http/tests/security/aboutBlank/security-context.html = TEXT
-BUGWKEFL : http/tests/security/cookies/assign-document-url.html = TEXT
-BUGWKEFL : http/tests/security/cookies/base-about-blank.html = TEXT
-BUGWKEFL : http/tests/security/cookies/base-tag.html = TEXT
-BUGWKEFL : http/tests/security/cookies/basic.html = TEXT
-BUGWKEFL : http/tests/security/cookies/document-open.html = TEXT
-
 // WebKitTestRunner needs an implementation for testRunner.setStorageDatabaseIdleInterval
 BUGWKEFL : storage/domstorage/storage-close-database-on-idle.html = TEXT
 
@@ -240,7 +224,6 @@
 BUGWKEFL : editing/input/emacs-ctrl-o.html = TEXT
 BUGWKEFL : editing/input/page-up-down-scrolls.html = TEXT
 BUGWKEFL : fast/block/float/float-in-float-hit-testing.html = TEXT
-BUGWKEFL : fast/cookies/local-file-can-set-cookies.html = TEXT
 BUGWKEFL : fast/css/bidi-override-in-anonymous-block.html = TEXT
 BUGWKEFL : fast/css/relative-positioned-block-crash.html = TEXT
 BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT

Modified: trunk/Source/WebKit2/ChangeLog (127581 => 127582)


--- trunk/Source/WebKit2/ChangeLog	2012-09-05 12:34:58 UTC (rev 127581)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-05 13:06:01 UTC (rev 127582)
@@ -1,3 +1,16 @@
+2012-09-05  Christophe Dumez  <christophe.du...@intel.com>
+
+        [EFL][WK2] Provide implementation for WebFrameNetworkingContext
+        https://bugs.webkit.org/show_bug.cgi?id=95826
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Remove EFL-specific and empty implementation for WebFrameNetworkingContext
+        and use the existing soup implementation instead.
+
+        * PlatformEfl.cmake:
+        * WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Removed.
+
 2012-09-05  Kaustubh Atrawalkar  <kaust...@motorola.com>
 
         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals

Modified: trunk/Source/WebKit2/PlatformEfl.cmake (127581 => 127582)


--- trunk/Source/WebKit2/PlatformEfl.cmake	2012-09-05 12:34:58 UTC (rev 127581)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2012-09-05 13:06:01 UTC (rev 127582)
@@ -108,6 +108,8 @@
     WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp
     WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp
 
+    WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp
+
     WebProcess/WebPage/efl/WebInspectorEfl.cpp
     WebProcess/WebPage/efl/WebPageEfl.cpp
 
@@ -139,6 +141,7 @@
     "${WEBKIT2_DIR}/WebProcess/efl"
     "${WEBKIT2_DIR}/WebProcess/soup"
     "${WEBKIT2_DIR}/WebProcess/WebCoreSupport/efl"
+    "${WEBKIT2_DIR}/WebProcess/WebCoreSupport/soup"
     "${WTF_DIR}/wtf/gobject"
     ${CAIRO_INCLUDE_DIRS}
     ${ECORE_X_INCLUDE_DIRS}

Deleted: trunk/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h (127581 => 127582)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h	2012-09-05 12:34:58 UTC (rev 127581)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h	2012-09-05 13:06:01 UTC (rev 127582)
@@ -1,52 +0,0 @@
-/*
- * Copyright (C) 2011 Samsung Electronics. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef WebFrameNetworkingContext_h
-#define WebFrameNetworkingContext_h
-
-#include "WebFrame.h"
-
-#include <WebCore/FrameNetworkingContext.h>
-
-class WebFrameNetworkingContext : public WebCore::FrameNetworkingContext {
-public:
-    static PassRefPtr<WebFrameNetworkingContext> create(WebKit::WebFrame*)
-    {
-        return 0;
-    }
-
-private:
-    explicit WebFrameNetworkingContext(WebKit::WebFrame* frame)
-        : WebCore::FrameNetworkingContext(frame->coreFrame())
-    {
-    }
-
-    virtual WTF::String userAgent() const;
-    virtual WTF::String referrer() const;
-
-    WTF::String m_userAgent;
-};
-
-#endif // WebFrameNetworkingContext_h
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to