Diff
Modified: trunk/Source/WebCore/ChangeLog (127751 => 127752)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 17:13:48 UTC (rev 127752)
@@ -1,3 +1,35 @@
+2012-09-06 Nikhil Bhargava <nbharg...@google.com>
+
+ Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
+ https://bugs.webkit.org/show_bug.cgi?id=95780
+
+ Reviewed by Eric Seidel.
+
+ Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
+ and Clipboard. There is a minor compile-time performance boost.
+
+ * Modules/mediastream/MediaStreamEvent.h:
+ * dom/Event.cpp:
+ * dom/Event.h:
+ (WebCore):
+ * dom/EventDispatchMediator.cpp:
+ * dom/EventListenerMap.cpp:
+ * dom/MouseRelatedEvent.h:
+ * dom/UIEvent.cpp:
+ * html/FormAssociatedElement.h:
+ (WebCore):
+ * inspector/TimelineRecordFactory.cpp:
+ * platform/graphics/FontPlatformData.h:
+ * rendering/RenderLineBoxList.h:
+ * rendering/style/RenderStyle.h:
+ (WebCore):
+ * svg/SVGAnimatedType.h:
+ * svg/SVGExternalResourcesRequired.cpp:
+ * svg/SVGExternalResourcesRequired.h:
+ (WebCore):
+ * svg/SVGURIReference.h:
+ (WebCore):
+
2012-09-06 Dan Bernstein <m...@apple.com>
REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp (127751 => 127752)
--- trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -43,6 +43,7 @@
#include "IDBTracing.h"
#include "IDBTransactionBackendImpl.h"
#include "ScriptExecutionContext.h"
+#include <wtf/MathExtras.h>
namespace WebCore {
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h (127751 => 127752)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -28,6 +28,7 @@
#if ENABLE(MEDIA_STREAM)
#include "Event.h"
+#include "MediaStream.h"
#include <wtf/text/AtomicString.h>
namespace WebCore {
Modified: trunk/Source/WebCore/dom/Event.cpp (127751 => 127752)
--- trunk/Source/WebCore/dom/Event.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/dom/Event.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -26,6 +26,7 @@
#include "EventDispatcher.h"
#include "EventNames.h"
#include "EventTarget.h"
+#include "MemoryInstrumentation.h"
#include "UserGestureIndicator.h"
#include <wtf/CurrentTime.h>
#include <wtf/text/AtomicString.h>
Modified: trunk/Source/WebCore/dom/Event.h (127751 => 127752)
--- trunk/Source/WebCore/dom/Event.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/dom/Event.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -24,17 +24,21 @@
#ifndef Event_h
#define Event_h
-#include "Clipboard.h"
#include "DOMTimeStamp.h"
+#include "EventNames.h"
+#include <wtf/HashMap.h>
+#include <wtf/ListHashSet.h>
#include <wtf/RefCounted.h>
#include <wtf/text/AtomicString.h>
namespace WebCore {
+class Clipboard;
class EventTarget;
class EventDispatcher;
class HTMLIFrameElement;
class MemoryInstrumentation;
+class MemoryObjectInfo;
struct EventInit {
EventInit();
Modified: trunk/Source/WebCore/dom/EventDispatchMediator.cpp (127751 => 127752)
--- trunk/Source/WebCore/dom/EventDispatchMediator.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/dom/EventDispatchMediator.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -33,6 +33,7 @@
#include "Event.h"
#include "EventDispatcher.h"
+#include "Node.h"
namespace WebCore {
Modified: trunk/Source/WebCore/dom/EventListenerMap.cpp (127751 => 127752)
--- trunk/Source/WebCore/dom/EventListenerMap.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/dom/EventListenerMap.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -35,6 +35,7 @@
#include "Event.h"
#include "EventException.h"
+#include "EventTarget.h"
#include <wtf/MainThread.h>
#include <wtf/StdLibExtras.h>
#include <wtf/Vector.h>
Modified: trunk/Source/WebCore/dom/MouseRelatedEvent.h (127751 => 127752)
--- trunk/Source/WebCore/dom/MouseRelatedEvent.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/dom/MouseRelatedEvent.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -24,7 +24,7 @@
#ifndef MouseRelatedEvent_h
#define MouseRelatedEvent_h
-#include "LayoutTypes.h"
+#include "LayoutTypesInlineMethods.h"
#include "UIEventWithKeyState.h"
namespace WebCore {
Modified: trunk/Source/WebCore/dom/UIEvent.cpp (127751 => 127752)
--- trunk/Source/WebCore/dom/UIEvent.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/dom/UIEvent.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -26,6 +26,7 @@
#include "Console.h"
#include "DOMWindow.h"
#include "EventDispatcher.h"
+#include "Node.h"
namespace WebCore {
Modified: trunk/Source/WebCore/html/FormAssociatedElement.h (127751 => 127752)
--- trunk/Source/WebCore/html/FormAssociatedElement.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/html/FormAssociatedElement.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -24,13 +24,18 @@
#ifndef FormAssociatedElement_h
#define FormAssociatedElement_h
-#include "HTMLElement.h"
+#include <wtf/text/WTFString.h>
namespace WebCore {
+class ContainerNode;
+class Document;
class FormAttributeTargetObserver;
class FormDataList;
+class HTMLElement;
class HTMLFormElement;
+class Node;
+class ShadowRoot;
class ValidationMessage;
class ValidityState;
class VisibleSelection;
Modified: trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp (127751 => 127752)
--- trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -37,6 +37,7 @@
#include "Event.h"
#include "InspectorValues.h"
#include "IntRect.h"
+#include "LayoutTypesInlineMethods.h"
#include "ResourceRequest.h"
#include "ResourceResponse.h"
#include "ScriptCallStack.h"
Modified: trunk/Source/WebCore/platform/graphics/FontPlatformData.h (127751 => 127752)
--- trunk/Source/WebCore/platform/graphics/FontPlatformData.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/platform/graphics/FontPlatformData.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -42,7 +42,6 @@
#include "FontOrientation.h"
#include "FontWidthVariant.h"
-#include "GlyphBuffer.h"
#include "TextOrientation.h"
#if PLATFORM(WIN)
Modified: trunk/Source/WebCore/rendering/RenderLineBoxList.h (127751 => 127752)
--- trunk/Source/WebCore/rendering/RenderLineBoxList.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/rendering/RenderLineBoxList.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -30,7 +30,7 @@
#ifndef RenderLineBoxList_h
#define RenderLineBoxList_h
-#include "RenderBox.h"
+#include "RenderObject.h"
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (127751 => 127752)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -34,7 +34,6 @@
#include "ColorSpace.h"
#include "CounterDirectives.h"
#include "DataRef.h"
-#include "FillLayer.h"
#include "FontBaseline.h"
#include "FontDescription.h"
#include "GraphicsTypes.h"
@@ -75,7 +74,6 @@
#include <wtf/Vector.h>
#if ENABLE(CSS_FILTERS)
-#include "FilterOperations.h"
#include "StyleFilterData.h"
#endif
@@ -102,6 +100,10 @@
using std::max;
+#if ENABLE(CSS_FILTERS)
+class FilterOperations;
+#endif
+
class BorderData;
class CounterContent;
class CursorList;
Modified: trunk/Source/WebCore/svg/SVGAnimatedType.h (127751 => 127752)
--- trunk/Source/WebCore/svg/SVGAnimatedType.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/svg/SVGAnimatedType.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -24,12 +24,12 @@
#include "FloatRect.h"
#include "SVGAngle.h"
#include "SVGColor.h"
-#include "SVGElement.h"
#include "SVGLength.h"
#include "SVGLengthList.h"
#include "SVGNumberList.h"
#include "SVGPointList.h"
#include "SVGPreserveAspectRatio.h"
+#include "SVGPropertyInfo.h"
#include "SVGTransformList.h"
namespace WebCore {
Modified: trunk/Source/WebCore/svg/SVGExternalResourcesRequired.cpp (127751 => 127752)
--- trunk/Source/WebCore/svg/SVGExternalResourcesRequired.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/svg/SVGExternalResourcesRequired.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -24,6 +24,7 @@
#include "SVGExternalResourcesRequired.h"
#include "Attr.h"
+#include "SVGElement.h"
#include "SVGNames.h"
namespace WebCore {
Modified: trunk/Source/WebCore/svg/SVGExternalResourcesRequired.h (127751 => 127752)
--- trunk/Source/WebCore/svg/SVGExternalResourcesRequired.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/svg/SVGExternalResourcesRequired.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -23,12 +23,12 @@
#if ENABLE(SVG)
#include "QualifiedName.h"
-#include "SVGElement.h"
#include <wtf/HashSet.h>
namespace WebCore {
class Attribute;
+class SVGElement;
// Notes on a SVG 1.1 spec discrepancy:
// The SVG DOM defines the attribute externalResourcesRequired as being of type SVGAnimatedBoolean, whereas the
Modified: trunk/Source/WebCore/svg/SVGURIReference.h (127751 => 127752)
--- trunk/Source/WebCore/svg/SVGURIReference.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/svg/SVGURIReference.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -22,13 +22,12 @@
#define SVGURIReference_h
#if ENABLE(SVG)
-#include "SVGElement.h"
+#include "Document.h"
#include "XLinkNames.h"
namespace WebCore {
class Attribute;
-class Document;
class Element;
class SVGURIReference {
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h (127751 => 127752)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -40,8 +40,9 @@
// FIXME: Eventually this should move to WebCore.
namespace WebCore {
- class Frame;
- class HTMLPlugInElement;
+class Frame;
+class HTMLPlugInElement;
+class RenderBoxModelObject;
}
namespace WebKit {
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h (127751 => 127752)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -40,12 +40,13 @@
#include <wtf/RetainPtr.h>
namespace WebCore {
- class Frame;
- class HTMLFrameOwnerElement;
+class Frame;
+class HTMLFrameOwnerElement;
+class IntRect;
#if ENABLE(WEB_INTENTS)
- class Intent;
+class Intent;
#endif
- class KURL;
+class KURL;
}
namespace WebKit {
Modified: trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp (127751 => 127752)
--- trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -34,6 +34,7 @@
#include <WebCore/NotImplemented.h>
#include <WebCore/PlatformContextCairo.h>
#include <WebCore/PrintContext.h>
+#include <WebCore/ResourceError.h>
#include <gtk/gtk.h>
#include <wtf/Vector.h>
#include <wtf/gobject/GOwnPtr.h>
