Title: [127888] trunk/Source/WebKit/chromium
- Revision
- 127888
- Author
- commit-qu...@webkit.org
- Date
- 2012-09-07 10:49:25 -0700 (Fri, 07 Sep 2012)
Log Message
[chromium] Clean up dependencies in ScrollbarLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96052
Patch by James Robinson <jam...@chromium.org> on 2012-09-07
Reviewed by Adrienne Walker.
Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
*) WebScrollbarImpl.h is #included, but not use
*) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if
WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.
* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127887 => 127888)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-07 17:46:43 UTC (rev 127887)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-07 17:49:25 UTC (rev 127888)
@@ -1,3 +1,18 @@
+2012-09-07 James Robinson <jam...@chromium.org>
+
+ [chromium] Clean up dependencies in ScrollbarLayerChromiumTest
+ https://bugs.webkit.org/show_bug.cgi?id=96052
+
+ Reviewed by Adrienne Walker.
+
+ Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
+ *) WebScrollbarImpl.h is #included, but not use
+ *) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if
+ WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.
+
+ * tests/ScrollbarLayerChromiumTest.cpp:
+ (WebCore::TEST):
+
2012-09-07 Dominic Mazzoni <dmazz...@google.com>
AX: ARIA spin button should support range value attributes
Modified: trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp (127887 => 127888)
--- trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp 2012-09-07 17:46:43 UTC (rev 127887)
+++ trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp 2012-09-07 17:49:25 UTC (rev 127888)
@@ -31,7 +31,6 @@
#include "CCSingleThreadProxy.h"
#include "FakeWebScrollbarThemeGeometry.h"
#include "TreeSynchronizer.h"
-#include "WebScrollbarImpl.h"
#include <gtest/gtest.h>
#include <public/WebScrollbar.h>
#include <public/WebScrollbarThemeGeometry.h>
@@ -68,7 +67,7 @@
{
DebugScopedSetImplThread impl;
- WebKit::WebScrollbarThemePainter painter(0, 0);
+ WebKit::WebScrollbarThemePainter painter;
{
OwnPtr<WebKit::WebScrollbar> scrollbar(FakeWebScrollbar::create());
@@ -109,7 +108,7 @@
{
DebugScopedSetImplThread impl;
- WebKit::WebScrollbarThemePainter painter(0, 0);
+ WebKit::WebScrollbarThemePainter painter;
OwnPtr<WebKit::WebScrollbar> scrollbar(FakeWebScrollbar::create());
RefPtr<LayerChromium> layerTreeRoot = LayerChromium::create();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
