Title: [127997] trunk/Source/WebCore
Revision
127997
Author
commit-qu...@webkit.org
Date
2012-09-09 14:21:10 -0700 (Sun, 09 Sep 2012)

Log Message

Unreviewed, rolling out r127979.
http://trac.webkit.org/changeset/127979
https://bugs.webkit.org/show_bug.cgi?id=96217

Appears to have broken the windows and linux builds (Requested
by jamesr_ on #webkit).

Patch by Sheriff Bot <webkit.review....@gmail.com> on 2012-09-09

* bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (127996 => 127997)


--- trunk/Source/WebCore/ChangeLog	2012-09-09 21:05:24 UTC (rev 127996)
+++ trunk/Source/WebCore/ChangeLog	2012-09-09 21:21:10 UTC (rev 127997)
@@ -1,3 +1,18 @@
+2012-09-09  Sheriff Bot  <webkit.review....@gmail.com>
+
+        Unreviewed, rolling out r127979.
+        http://trac.webkit.org/changeset/127979
+        https://bugs.webkit.org/show_bug.cgi?id=96217
+
+        Appears to have broken the windows and linux builds (Requested
+        by jamesr_ on #webkit).
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (NativeToJSValue):
+        * bindings/v8/V8DOMWrapper.h:
+        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
+        (V8DOMWrapper):
+
 2012-09-09  James Robinson  <jam...@chromium.org>
 
         [chromium] webkit_platform should only be linked into the webkit target

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (127996 => 127997)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-09-09 21:05:24 UTC (rev 127996)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-09-09 21:21:10 UTC (rev 127997)
@@ -4062,7 +4062,7 @@
     }
 
     if ($type eq "EventTarget") {
-        return "V8DOMWrapper::convertEventTargetToV8Object(WTF::getPtr($value)$getCreationContextArg$getIsolateArg)";
+        return "V8DOMWrapper::convertEventTargetToV8Object($value$getCreationContextArg$getIsolateArg)";
     }
 
     if ($type eq "EventListener") {

Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h (127996 => 127997)


--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h	2012-09-09 21:05:24 UTC (rev 127996)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h	2012-09-09 21:21:10 UTC (rev 127997)
@@ -81,6 +81,11 @@
 
         static WrapperTypeInfo* domWrapperType(v8::Handle<v8::Object>);
 
+        static v8::Handle<v8::Value> convertEventTargetToV8Object(PassRefPtr<EventTarget> eventTarget, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* isolate = 0)
+        {
+            return convertEventTargetToV8Object(eventTarget.get(), creationContext, isolate);
+        }
+
         static v8::Handle<v8::Value> convertEventTargetToV8Object(EventTarget*, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* = 0);
 
         static PassRefPtr<EventListener> getEventListener(v8::Local<v8::Value> value, bool isAttribute, ListenerLookupType lookup);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to