Title: [128171] trunk/Source/WebCore
Revision
128171
Author
apav...@chromium.org
Date
2012-09-11 04:54:59 -0700 (Tue, 11 Sep 2012)

Log Message

Web Inspector: Remove no-op TreeElement.prototype.didChange method
https://bugs.webkit.org/show_bug.cgi?id=96376

Reviewed by Yury Semikhatsky.

* inspector/front-end/treeoutline.js:
(TreeElement.prototype.set title):
(TreeElement.prototype.set tooltip):
(TreeElement.prototype.set hasChildren):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (128170 => 128171)


--- trunk/Source/WebCore/ChangeLog	2012-09-11 11:26:26 UTC (rev 128170)
+++ trunk/Source/WebCore/ChangeLog	2012-09-11 11:54:59 UTC (rev 128171)
@@ -1,3 +1,15 @@
+2012-09-11  Alexander Pavlov  <apav...@chromium.org>
+
+        Web Inspector: Remove no-op TreeElement.prototype.didChange method
+        https://bugs.webkit.org/show_bug.cgi?id=96376
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/treeoutline.js:
+        (TreeElement.prototype.set title):
+        (TreeElement.prototype.set tooltip):
+        (TreeElement.prototype.set hasChildren):
+
 2012-09-11  Tommy Widenflycht  <tom...@google.com>
 
         MediaStream API: add RTCPeerConnection::onnegotiationneeded

Modified: trunk/Source/WebCore/inspector/front-end/treeoutline.js (128170 => 128171)


--- trunk/Source/WebCore/inspector/front-end/treeoutline.js	2012-09-11 11:26:26 UTC (rev 128170)
+++ trunk/Source/WebCore/inspector/front-end/treeoutline.js	2012-09-11 11:54:59 UTC (rev 128171)
@@ -623,7 +623,6 @@
     set title(x) {
         this._title = x;
         this._setListItemNodeContent();
-        this.didChange();
     },
 
     get tooltip() {
@@ -634,7 +633,6 @@
         this._tooltip = x;
         if (this._listItemNode)
             this._listItemNode.title = x ? x : "";
-        this.didChange();
     },
 
     get hasChildren() {
@@ -656,8 +654,6 @@
             this._listItemNode.classList.remove("parent");
             this.collapse();
         }
-
-        this.didChange();
     },
 
     get hidden() {
@@ -693,21 +689,6 @@
             this.expand();
     },
 
-    _fireDidChange: function()
-    {
-        delete this._didChangeTimeoutIdentifier;
-    },
-
-    didChange: function()
-    {
-        if (!this.treeOutline)
-            return;
-
-        // Prevent telling the TreeOutline multiple times in a row by delaying it with a timeout.
-        if (!this._didChangeTimeoutIdentifier)
-            this._didChangeTimeoutIdentifier = setTimeout(this._fireDidChange.bind(this), 0);
-    },
-
     _setListItemNodeContent: function()
     {
         if (!this._listItemNode)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to