Title: [128327] trunk/Tools
- Revision
- 128327
- Author
- commit-qu...@webkit.org
- Date
- 2012-09-12 09:41:58 -0700 (Wed, 12 Sep 2012)
Log Message
[EFL] [WK2] Memory leaks in TestControllerEfl
https://bugs.webkit.org/show_bug.cgi?id=96525
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.
Fix memory leaks in EFL's TestRunner code by adopting an allocation
of WKString created with WKStringCreateWithUTF8CString().
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (128326 => 128327)
--- trunk/Tools/ChangeLog 2012-09-12 16:38:16 UTC (rev 128326)
+++ trunk/Tools/ChangeLog 2012-09-12 16:41:58 UTC (rev 128327)
@@ -1,3 +1,17 @@
+2012-09-12 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ [EFL] [WK2] Memory leaks in TestControllerEfl
+ https://bugs.webkit.org/show_bug.cgi?id=96525
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Fix memory leaks in EFL's TestRunner code by adopting an allocation
+ of WKString created with WKStringCreateWithUTF8CString().
+
+ * WebKitTestRunner/efl/TestControllerEfl.cpp:
+ (WTR::TestController::initializeInjectedBundlePath):
+ (WTR::TestController::initializeTestPluginDirectory):
+
2012-09-12 Christophe Dumez <christophe.du...@intel.com>
[WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
Modified: trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp (128326 => 128327)
--- trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2012-09-12 16:38:16 UTC (rev 128326)
+++ trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2012-09-12 16:41:58 UTC (rev 128327)
@@ -85,13 +85,13 @@
void TestController::initializeInjectedBundlePath()
{
const char* bundlePath = getEnvironmentVariableOrExit("TEST_RUNNER_INJECTED_BUNDLE_FILENAME");
- m_injectedBundlePath = WKStringCreateWithUTF8CString(bundlePath);
+ m_injectedBundlePath.adopt(WKStringCreateWithUTF8CString(bundlePath));
}
void TestController::initializeTestPluginDirectory()
{
const char* pluginPath = getEnvironmentVariableOrExit("TEST_RUNNER_PLUGIN_PATH");
- m_testPluginDirectory = WKStringCreateWithUTF8CString(pluginPath);
+ m_testPluginDirectory.adopt(WKStringCreateWithUTF8CString(pluginPath));
}
void TestController::platformInitializeContext()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
