Title: [128332] trunk/Source/WebCore
- Revision
- 128332
- Author
- dmazz...@google.com
- Date
- 2012-09-12 09:57:16 -0700 (Wed, 12 Sep 2012)
Log Message
Assert hit in is multiSelectable()
https://bugs.webkit.org/show_bug.cgi?id=96530
Reviewed by Chris Fleizach.
Fix crash if element isn't a select element.
This bug slipped through in a refactoring change (bug 96323).
Covered by existing tests.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isMultiSelectable):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (128331 => 128332)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 16:54:55 UTC (rev 128331)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 16:57:16 UTC (rev 128332)
@@ -1,3 +1,18 @@
+2012-09-12 Dominic Mazzoni <dmazz...@google.com>
+
+ Assert hit in is multiSelectable()
+ https://bugs.webkit.org/show_bug.cgi?id=96530
+
+ Reviewed by Chris Fleizach.
+
+ Fix crash if element isn't a select element.
+
+ This bug slipped through in a refactoring change (bug 96323).
+ Covered by existing tests.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::isMultiSelectable):
+
2012-09-11 MORITA Hajime <morr...@google.com>
[Scoped Style] NodeRareData::m_numberOfScopedHTMLStyleChildren could be replaced with a node flag.
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (128331 => 128332)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2012-09-12 16:54:55 UTC (rev 128331)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2012-09-12 16:57:16 UTC (rev 128332)
@@ -622,7 +622,7 @@
if (equalIgnoringCase(ariaMultiSelectable, "false"))
return false;
- return node() && toHTMLSelectElement(node())->multiple();
+ return node() && node()->hasTagName(selectTag) && toHTMLSelectElement(node())->multiple();
}
bool AccessibilityNodeObject::isReadOnly() const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
