Title: [128622] trunk/Source/WebKit/blackberry
- Revision
- 128622
- Author
- mifen...@rim.com
- Date
- 2012-09-14 09:58:59 -0700 (Fri, 14 Sep 2012)
Log Message
[BlackBerry] Update the minimum zoom scale when focusing an input field.
https://bugs.webkit.org/show_bug.cgi?id=96789
Reviewed by Antonio Gomes.
PR 188751.
Increase the minimum font fix and base it on mm instead of pixels.
Reviewed Internally by Gen Mak.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (128621 => 128622)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-14 16:55:35 UTC (rev 128621)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-14 16:58:59 UTC (rev 128622)
@@ -1,3 +1,19 @@
+2012-09-14 Mike Fenton <mifen...@rim.com>
+
+ [BlackBerry] Update the minimum zoom scale when focusing an input field.
+ https://bugs.webkit.org/show_bug.cgi?id=96789
+
+ Reviewed by Antonio Gomes.
+
+ PR 188751.
+
+ Increase the minimum font fix and base it on mm instead of pixels.
+
+ Reviewed Internally by Gen Mak.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
+
2012-09-13 Antonio Gomes <ago...@rim.com>
[BlackBerry] Remove the ability to schedule a zoom about point call.
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (128621 => 128622)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-09-14 16:55:35 UTC (rev 128621)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-09-14 16:58:59 UTC (rev 128622)
@@ -66,6 +66,7 @@
#include <BlackBerryPlatformKeyboardEvent.h>
#include <BlackBerryPlatformLog.h>
#include <BlackBerryPlatformMisc.h>
+#include <BlackBerryPlatformScreen.h>
#include <BlackBerryPlatformSettings.h>
#include <sys/keycodes.h>
#include <wtf/text/CString.h>
@@ -1158,9 +1159,10 @@
}
// If the text is too small, zoom in to make it a minimum size.
- static const int s_minimumTextHeightInPixels = 6;
+ // The minimum size being defined as 3 mm is a good value based on my observations.
+ static const int s_minimumTextHeightInPixels = Graphics::Screen::primaryScreen()->widthInMMToPixels(3);
if (fontHeight && fontHeight < s_minimumTextHeightInPixels)
- m_webPage->zoomAboutPoint(s_minimumTextHeightInPixels / fontHeight, m_webPage->centerOfVisibleContentsRect());
+ m_webPage->zoomAboutPoint(s_minimumTextHeightInPixels / fontHeight, selectionFocusRect.location());
}
void InputHandler::ensureFocusPluginElementVisible()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
