Title: [128923] trunk/Source/WebKit/blackberry
- Revision
- 128923
- Author
- [email protected]
- Date
- 2012-09-18 12:55:55 -0700 (Tue, 18 Sep 2012)
Log Message
[BlackBerry] Date picker isn't inputting after 'OK'
https://bugs.webkit.org/show_bug.cgi?id=97031
PR208052
Patch by Jessica Cao <[email protected]> on 2012-09-18
Reviewed by Rob Buis
Checking for !values.contains("-1") will match valid strings like "2012-09-18". Use value != "-1" instead.
* WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValueAndClosePopup):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (128922 => 128923)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-18 19:37:02 UTC (rev 128922)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-18 19:55:55 UTC (rev 128923)
@@ -1,3 +1,17 @@
+2012-09-18 Jessica Cao <[email protected]>
+
+ [BlackBerry] Date picker isn't inputting after 'OK'
+ https://bugs.webkit.org/show_bug.cgi?id=97031
+
+ PR208052
+
+ Reviewed by Rob Buis
+
+ Checking for !values.contains("-1") will match valid strings like "2012-09-18". Use value != "-1" instead.
+
+ * WebCoreSupport/DatePickerClient.cpp:
+ (WebCore::DatePickerClient::setValueAndClosePopup):
+
2012-09-18 Yong Li <[email protected]>
[BlackBerry] Popup page should reference the client with a weak pointer
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp (128922 => 128923)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp 2012-09-18 19:37:02 UTC (rev 128922)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp 2012-09-18 19:55:55 UTC (rev 128923)
@@ -123,7 +123,7 @@
// Return -1 if user cancel the selection.
ASSERT(m_element);
- if (!value.contains("-1"))
+ if (value != "-1")
m_element->setValue(value);
closePopup();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
