Title: [129433] trunk/Source
- Revision
- 129433
- Author
- [email protected]
- Date
- 2012-09-24 17:28:51 -0700 (Mon, 24 Sep 2012)
Log Message
Remove String::operator+=()
https://bugs.webkit.org/show_bug.cgi?id=96172
Reviewed by Benjamin Poulain.
Source/WebCore:
Replace the last usage with String::append() in Gtk.
* platform/gtk/GtkInputMethodFilter.cpp:
(WebCore::GtkInputMethodFilter::handleCommit):
Source/WTF:
* wtf/Platform.h:
* wtf/text/WTFString.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (129432 => 129433)
--- trunk/Source/WTF/ChangeLog 2012-09-25 00:20:13 UTC (rev 129432)
+++ trunk/Source/WTF/ChangeLog 2012-09-25 00:28:51 UTC (rev 129433)
@@ -1,3 +1,13 @@
+2012-09-24 Patrick Gansterer <[email protected]>
+
+ Remove String::operator+=()
+ https://bugs.webkit.org/show_bug.cgi?id=96172
+
+ Reviewed by Benjamin Poulain.
+
+ * wtf/Platform.h:
+ * wtf/text/WTFString.h:
+
2012-09-24 Benjamin Poulain <[email protected]>
Add support for query encoding to WTFURL
Modified: trunk/Source/WTF/wtf/Platform.h (129432 => 129433)
--- trunk/Source/WTF/wtf/Platform.h 2012-09-25 00:20:13 UTC (rev 129432)
+++ trunk/Source/WTF/wtf/Platform.h 2012-09-25 00:28:51 UTC (rev 129433)
@@ -1181,10 +1181,6 @@
#define WTF_USE_ZLIB 1
#endif
-#if PLATFORM(GTK)
-#define WTF_DEPRECATED_STRING_OPERATORS
-#endif
-
#if PLATFORM(QT)
#include <qglobal.h>
#if defined(QT_OPENGL_ES_2) && !defined(WTF_USE_OPENGL_ES_2)
Modified: trunk/Source/WTF/wtf/text/WTFString.h (129432 => 129433)
--- trunk/Source/WTF/wtf/text/WTFString.h 2012-09-25 00:20:13 UTC (rev 129432)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2012-09-25 00:28:51 UTC (rev 129433)
@@ -467,10 +467,6 @@
QDataStream& operator>>(QDataStream& stream, String& str);
#endif
-#ifdef WTF_DEPRECATED_STRING_OPERATORS
-inline String& operator+=(String& a, const String& b) { a.append(b); return a; }
-#endif
-
inline bool operator==(const String& a, const String& b) { return equal(a.impl(), b.impl()); }
inline bool operator==(const String& a, const LChar* b) { return equal(a.impl(), b); }
inline bool operator==(const String& a, const char* b) { return equal(a.impl(), reinterpret_cast<const LChar*>(b)); }
Modified: trunk/Source/WebCore/ChangeLog (129432 => 129433)
--- trunk/Source/WebCore/ChangeLog 2012-09-25 00:20:13 UTC (rev 129432)
+++ trunk/Source/WebCore/ChangeLog 2012-09-25 00:28:51 UTC (rev 129433)
@@ -1,3 +1,15 @@
+2012-09-24 Patrick Gansterer <[email protected]>
+
+ Remove String::operator+=()
+ https://bugs.webkit.org/show_bug.cgi?id=96172
+
+ Reviewed by Benjamin Poulain.
+
+ Replace the last usage with String::append() in Gtk.
+
+ * platform/gtk/GtkInputMethodFilter.cpp:
+ (WebCore::GtkInputMethodFilter::handleCommit):
+
2012-09-24 Mark Pilgrim <[email protected]>
[Chromium][Mac] Remove loadFont from PlatformSupport
Modified: trunk/Source/WebCore/platform/gtk/GtkInputMethodFilter.cpp (129432 => 129433)
--- trunk/Source/WebCore/platform/gtk/GtkInputMethodFilter.cpp 2012-09-25 00:20:13 UTC (rev 129432)
+++ trunk/Source/WebCore/platform/gtk/GtkInputMethodFilter.cpp 2012-09-25 00:28:51 UTC (rev 129433)
@@ -292,7 +292,7 @@
if (!m_enabled)
return;
- m_confirmedComposition += String::fromUTF8(compositionString);
+ m_confirmedComposition.append(String::fromUTF8(compositionString));
// If the commit was triggered outside of a key event, just send
// the IME event now. If we are handling a key event, we'll decide
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
