Title: [129550] trunk/Source/WebKit/blackberry
- Revision
- 129550
- Author
- mifen...@rim.com
- Date
- 2012-09-25 13:44:19 -0700 (Tue, 25 Sep 2012)
Log Message
[BlackBerry] Suspend the backingstore while adjusting the view on input field focus.
https://bugs.webkit.org/show_bug.cgi?id=97595
Reviewed by Antonio Gomes.
PR 188751.
Avoid jumpiness when both a scroll and zoom are required to
move an input field into focus by suspending the backingstore.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (129549 => 129550)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-25 20:40:30 UTC (rev 129549)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-25 20:44:19 UTC (rev 129550)
@@ -1,3 +1,18 @@
+2012-09-25 Mike Fenton <mifen...@rim.com>
+
+ [BlackBerry] Suspend the backingstore while adjusting the view on input field focus.
+ https://bugs.webkit.org/show_bug.cgi?id=97595
+
+ Reviewed by Antonio Gomes.
+
+ PR 188751.
+
+ Avoid jumpiness when both a scroll and zoom are required to
+ move an input field into focus by suspending the backingstore.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
+
2012-09-25 Pratik Solanki <psola...@apple.com>
Remove HAVE_SBRK since we never set use_sbrk to true
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (129549 => 129550)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-09-25 20:40:30 UTC (rev 129549)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-09-25 20:44:19 UTC (rev 129550)
@@ -1060,6 +1060,8 @@
int fontHeight = selectionFocusRect.height();
+ m_webPage->suspendBackingStore();
+
// If the text is too small, zoom in to make it a minimum size.
// The minimum size being defined as 3 mm is a good value based on my observations.
static const int s_minimumTextHeightInPixels = Graphics::Screen::primaryScreen()->heightInMMToPixels(3);
@@ -1146,6 +1148,7 @@
mainFrameView->setConstrainsScrollingToContentEdge(true);
}
}
+ m_webPage->resumeBackingStore();
}
void InputHandler::ensureFocusPluginElementVisible()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
