Title: [130262] trunk/Tools
Revision
130262
Author
[email protected]
Date
2012-10-03 01:43:40 -0700 (Wed, 03 Oct 2012)

Log Message

[WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
https://bugs.webkit.org/show_bug.cgi?id=98238

Patch by Christophe Dumez <[email protected]> on 2012-10-03
Reviewed by Csaba Osztrogonác.

Reset AlwaysAcceptCookies setting between tests to avoid
flakiness due to TestRunner.setAlwaysAcceptCookies().

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (130261 => 130262)


--- trunk/Tools/ChangeLog	2012-10-03 08:33:59 UTC (rev 130261)
+++ trunk/Tools/ChangeLog	2012-10-03 08:43:40 UTC (rev 130262)
@@ -1,3 +1,16 @@
+2012-10-03  Christophe Dumez  <[email protected]>
+
+        [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
+        https://bugs.webkit.org/show_bug.cgi?id=98238
+
+        Reviewed by Csaba Osztrogonác.
+
+        Reset AlwaysAcceptCookies setting between tests to avoid
+        flakiness due to TestRunner.setAlwaysAcceptCookies().
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+        (WTR::InjectedBundle::beginTesting):
+
 2012-10-03  Harald Alvestrand  <[email protected]>
 
         Add data passing to the GetStats interface of RTCPeerConnection

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (130261 => 130262)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp	2012-10-03 08:33:59 UTC (rev 130261)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp	2012-10-03 08:43:40 UTC (rev 130262)
@@ -245,6 +245,7 @@
     WKBundleSetAllowFileAccessFromFileURLs(m_bundle, m_pageGroup, true);
     WKBundleSetPluginsEnabled(m_bundle, m_pageGroup, true);
     WKBundleSetPopupBlockingEnabled(m_bundle, m_pageGroup, false);
+    WKBundleSetAlwaysAcceptCookies(m_bundle, false);
 
     WKBundleRemoveAllUserContent(m_bundle, m_pageGroup);
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to