Title: [130271] trunk
Revision
130271
Author
[email protected]
Date
2012-10-03 02:52:57 -0700 (Wed, 03 Oct 2012)

Log Message

[Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
https://bugs.webkit.org/show_bug.cgi?id=98200

Patch by Raphael Kubo da Costa <[email protected]> on 2012-10-03
Reviewed by Csaba Osztrogonác.

Tools:

* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::overridePreference):

LayoutTests:

* platform/qt/TestExpectations: Unskip a few tests that depended
on this feature.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (130270 => 130271)


--- trunk/LayoutTests/ChangeLog	2012-10-03 09:52:19 UTC (rev 130270)
+++ trunk/LayoutTests/ChangeLog	2012-10-03 09:52:57 UTC (rev 130271)
@@ -1,3 +1,13 @@
+2012-10-03  Raphael Kubo da Costa  <[email protected]>
+
+        [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
+        https://bugs.webkit.org/show_bug.cgi?id=98200
+
+        Reviewed by Csaba Osztrogonác.
+
+        * platform/qt/TestExpectations: Unskip a few tests that depended
+        on this feature.
+
 2012-10-03  Jochen Eisinger  <[email protected]>
 
         Make sure that user gestures can't be consumed twice

Modified: trunk/LayoutTests/platform/qt/TestExpectations (130270 => 130271)


--- trunk/LayoutTests/platform/qt/TestExpectations	2012-10-03 09:52:19 UTC (rev 130270)
+++ trunk/LayoutTests/platform/qt/TestExpectations	2012-10-03 09:52:57 UTC (rev 130271)
@@ -1327,13 +1327,6 @@
 css3/filters/custom/filter-repaint-custom-rotated.html
 css3/filters/custom/filter-repaint-custom.html
 
-# ERROR: TestRunner::overridePreference() does not support the 'WebKitDisplayImagesKey' preference
-# http://trac.webkit.org/changeset/129462
-fast/loader/display-image-unset-allows-cached-image-load.html
-fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
-fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html
-http/tests/misc/favicon-loads-with-images-disabled.html
-
 # ReferenceError: Can't find variable: MediaKeyError
 # http://trac.webkit.org/changeset/114067
 fast/events/constructors/media-key-event-constructor.html

Modified: trunk/Tools/ChangeLog (130270 => 130271)


--- trunk/Tools/ChangeLog	2012-10-03 09:52:19 UTC (rev 130270)
+++ trunk/Tools/ChangeLog	2012-10-03 09:52:57 UTC (rev 130271)
@@ -1,3 +1,13 @@
+2012-10-03  Raphael Kubo da Costa  <[email protected]>
+
+        [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
+        https://bugs.webkit.org/show_bug.cgi?id=98200
+
+        Reviewed by Csaba Osztrogonác.
+
+        * DumpRenderTree/qt/TestRunnerQt.cpp:
+        (TestRunner::overridePreference):
+
 2012-10-03  Zoltan Arvai  <[email protected]>
 
         [Qt][WRT] Fix build error with MSVC on Windows.

Modified: trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp (130270 => 130271)


--- trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp	2012-10-03 09:52:19 UTC (rev 130270)
+++ trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp	2012-10-03 09:52:57 UTC (rev 130271)
@@ -677,6 +677,8 @@
         settings->setAttribute(QWebSettings::HyperlinkAuditingEnabled, value.toBool());
     else if (name == "WebKitAcceleratedCompositingEnabled")
         settings->setAttribute(QWebSettings::AcceleratedCompositingEnabled, value.toBool());
+    else if (name == "WebKitDisplayImagesKey")
+        settings->setAttribute(QWebSettings::AutoLoadImages, value.toBool());
     else
         printf("ERROR: TestRunner::overridePreference() does not support the '%s' preference\n",
             name.toLatin1().data());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to