Title: [130466] trunk
- Revision
- 130466
- Author
- commit-qu...@webkit.org
- Date
- 2012-10-04 23:22:19 -0700 (Thu, 04 Oct 2012)
Log Message
[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98256
Patch by Christophe Dumez <christophe.du...@intel.com> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.
Tools:
Implement UIClient's focus callbacks in WebKitTestRunner.
* WebKitTestRunner/TestController.cpp:
(WTR::focus):
(WTR::TestController::initialize):
LayoutTests:
Unskip fast/dom/Window/mozilla-focus-blur.html now that
WebKitTestRunner implements UIClient's focus callbacks.
* platform/efl-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (130465 => 130466)
--- trunk/LayoutTests/ChangeLog 2012-10-05 06:15:20 UTC (rev 130465)
+++ trunk/LayoutTests/ChangeLog 2012-10-05 06:22:19 UTC (rev 130466)
@@ -1,3 +1,15 @@
+2012-10-04 Christophe Dumez <christophe.du...@intel.com>
+
+ [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
+ https://bugs.webkit.org/show_bug.cgi?id=98256
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskip fast/dom/Window/mozilla-focus-blur.html now that
+ WebKitTestRunner implements UIClient's focus callbacks.
+
+ * platform/efl-wk2/TestExpectations:
+
2012-10-04 Rik Cabanier <caban...@adobe.com>
Turn Compositing on by default in WebKit build
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (130465 => 130466)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-10-05 06:15:20 UTC (rev 130465)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-10-05 06:22:19 UTC (rev 130466)
@@ -198,7 +198,6 @@
webkit.org/b/93982 storage/domstorage/storage-close-database-on-idle.html [ Failure ]
# Unclassified failures
-Bug(EFL) fast/dom/Window/mozilla-focus-blur.html [ Failure ]
Bug(EFL) http/tests/inspector/network/network-sidebar-width.html [ Failure ]
# Fails after r128056.
Modified: trunk/Tools/ChangeLog (130465 => 130466)
--- trunk/Tools/ChangeLog 2012-10-05 06:15:20 UTC (rev 130465)
+++ trunk/Tools/ChangeLog 2012-10-05 06:22:19 UTC (rev 130466)
@@ -1,3 +1,16 @@
+2012-10-04 Christophe Dumez <christophe.du...@intel.com>
+
+ [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
+ https://bugs.webkit.org/show_bug.cgi?id=98256
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Implement UIClient's focus callbacks in WebKitTestRunner.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::focus):
+ (WTR::TestController::initialize):
+
2012-10-04 Rik Cabanier <caban...@adobe.com>
Turn Compositing on by default in WebKit build
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (130465 => 130466)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2012-10-05 06:15:20 UTC (rev 130465)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2012-10-05 06:22:19 UTC (rev 130466)
@@ -163,6 +163,7 @@
static void focus(WKPageRef page, const void* clientInfo)
{
PlatformWebView* view = static_cast<PlatformWebView*>(const_cast<void*>(clientInfo));
+ view->focus();
view->setWindowIsKey(true);
}
@@ -362,8 +363,8 @@
0, // showPage
0, // close
0, // takeFocus
- 0, // focus
- 0, // unfocus
+ focus,
+ unfocus,
0, // runJavaScriptAlert
0, // runJavaScriptConfirm
0, // runJavaScriptPrompt
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
