Title: [131325] trunk/Source/WebCore
- Revision
- 131325
- Author
- morr...@google.com
- Date
- 2012-10-15 11:26:18 -0700 (Mon, 15 Oct 2012)
Log Message
[Regression r131167] run-webkit-tests fails
https://bugs.webkit.org/show_bug.cgi?id=99279
Reviewed by Kentaro Hara.
CodeGeneratorV8.pm assumed that there are only two objects which have constructor getters and
overlooked TestObj. This fix relaxes that assumption to accept it.
No new tests. Fixing an existing test.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::TestObjConstructorGetter):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131324 => 131325)
--- trunk/Source/WebCore/ChangeLog 2012-10-15 18:14:26 UTC (rev 131324)
+++ trunk/Source/WebCore/ChangeLog 2012-10-15 18:26:18 UTC (rev 131325)
@@ -1,3 +1,20 @@
+2012-10-15 MORITA Hajime <morr...@google.com>
+
+ [Regression r131167] run-webkit-tests fails
+ https://bugs.webkit.org/show_bug.cgi?id=99279
+
+ Reviewed by Kentaro Hara.
+
+ CodeGeneratorV8.pm assumed that there are only two objects which have constructor getters and
+ overlooked TestObj. This fix relaxes that assumption to accept it.
+
+ No new tests. Fixing an existing test.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateConstructorGetter):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjV8Internal::TestObjConstructorGetter):
+
2012-10-15 Joe Mason <jma...@rim.com>
[BlackBerry] Fix WebSockets which was disabled by recent string changes
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (131324 => 131325)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-10-15 18:14:26 UTC (rev 131324)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-10-15 18:26:18 UTC (rev 131325)
@@ -835,12 +835,9 @@
END
} elsif ($implClassName eq "WorkerContext") {
push(@implContentDecls, " return perContextData->constructorForType(WrapperTypeInfo::unwrap(data), V8WorkerContext::toNative(info.Holder()));\n")
+ } else {
+ push(@implContentDecls, " return perContextData->constructorForType(WrapperTypeInfo::unwrap(data), 0);\n");
}
- # FIXME: This code is correct for real IDL files, but fails with TestObj.idl,
- # which contains methods with [V8EnabledPerContext].
- # else {
- # die "Unknown Context ${implClassName}"
- # }
push(@implContentDecls, <<END);
}
END
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (131324 => 131325)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-10-15 18:14:26 UTC (rev 131324)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-10-15 18:26:18 UTC (rev 131325)
@@ -1031,6 +1031,7 @@
V8PerContextData* perContextData = V8PerContextData::from(info.Holder()->CreationContext());
if (!perContextData)
return v8Undefined();
+ return perContextData->constructorForType(WrapperTypeInfo::unwrap(data), 0);
}
static void TestObjReplaceableAttrSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
