Title: [131343] trunk/Source/WebCore
- Revision
- 131343
- Author
- commit-qu...@webkit.org
- Date
- 2012-10-15 13:05:36 -0700 (Mon, 15 Oct 2012)
Log Message
Web Inspector: Fix memory leak in TreeOutline
https://bugs.webkit.org/show_bug.cgi?id=99307
Patch by Eugene Klyuchnikov <eustas....@gmail.com> on 2012-10-15
Reviewed by Alexander Pavlov.
Added cleanup of empty buckets in elements cache.
* inspector/front-end/treeoutline.js:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131342 => 131343)
--- trunk/Source/WebCore/ChangeLog 2012-10-15 20:03:37 UTC (rev 131342)
+++ trunk/Source/WebCore/ChangeLog 2012-10-15 20:05:36 UTC (rev 131343)
@@ -1,5 +1,16 @@
2012-10-15 Eugene Klyuchnikov <eustas....@gmail.com>
+ Web Inspector: Fix memory leak in TreeOutline
+ https://bugs.webkit.org/show_bug.cgi?id=99307
+
+ Reviewed by Alexander Pavlov.
+
+ Added cleanup of empty buckets in elements cache.
+
+ * inspector/front-end/treeoutline.js:
+
+2012-10-15 Eugene Klyuchnikov <eustas....@gmail.com>
+
Web Inspector: Hide useless controls in remote-debugging mode.
https://bugs.webkit.org/show_bug.cgi?id=99300
Modified: trunk/Source/WebCore/inspector/front-end/treeoutline.js (131342 => 131343)
--- trunk/Source/WebCore/inspector/front-end/treeoutline.js 2012-10-15 20:03:37 UTC (rev 131342)
+++ trunk/Source/WebCore/inspector/front-end/treeoutline.js 2012-10-15 20:05:36 UTC (rev 131343)
@@ -208,8 +208,12 @@
TreeOutline.prototype._forgetTreeElement = function(element)
{
- if (this._treeElementsMap.get(element.representedObject))
- this._treeElementsMap.get(element.representedObject).remove(element, true);
+ if (this._treeElementsMap.get(element.representedObject)) {
+ var elements = this._treeElementsMap.get(element.representedObject);
+ elements.remove(element, true);
+ if (!elements.length)
+ this._treeElementsMap.remove(element.representedObject);
+ }
}
TreeOutline.prototype._forgetChildrenRecursive = function(parentElement)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
