- Revision
- 131347
- Author
- commit-qu...@webkit.org
- Date
- 2012-10-15 13:23:51 -0700 (Mon, 15 Oct 2012)
Log Message
[EFL][WK2] Provide implementation for PageClientImpl::toolTipChanged()
https://bugs.webkit.org/show_bug.cgi?id=98589
Patch by Jinwoo Song <jinwoo7.s...@samsung.com> on 2012-10-15
Reviewed by Kenneth Rohde Christiansen.
Implement PageClientImpl::toolTipChanged() to emit signal 'tooltip,text,set' with a tooltip text,
or 'tooltip,text,unset' if tooltip was unset.
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::toolTipChanged):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_tooltip_text_set):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_private.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (131346 => 131347)
--- trunk/Source/WebKit2/ChangeLog 2012-10-15 20:22:03 UTC (rev 131346)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-15 20:23:51 UTC (rev 131347)
@@ -1,3 +1,20 @@
+2012-10-15 Jinwoo Song <jinwoo7.s...@samsung.com>
+
+ [EFL][WK2] Provide implementation for PageClientImpl::toolTipChanged()
+ https://bugs.webkit.org/show_bug.cgi?id=98589
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Implement PageClientImpl::toolTipChanged() to emit signal 'tooltip,text,set' with a tooltip text,
+ or 'tooltip,text,unset' if tooltip was unset.
+
+ * UIProcess/API/efl/PageClientImpl.cpp:
+ (WebKit::PageClientImpl::toolTipChanged):
+ * UIProcess/API/efl/ewk_view.cpp:
+ (ewk_view_tooltip_text_set):
+ * UIProcess/API/efl/ewk_view.h:
+ * UIProcess/API/efl/ewk_view_private.h:
+
2012-10-15 Roger Fong <roger_f...@apple.com>
Unreviewed. Partial build fix for Windows after r131308.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp (131346 => 131347)
--- trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp 2012-10-15 20:22:03 UTC (rev 131346)
+++ trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp 2012-10-15 20:23:51 UTC (rev 131347)
@@ -123,9 +123,9 @@
notImplemented();
}
-void PageClientImpl::toolTipChanged(const String&, const String&)
+void PageClientImpl::toolTipChanged(const String&, const String& newToolTip)
{
- notImplemented();
+ ewk_view_tooltip_text_set(m_viewWidget, newToolTip.utf8().data());
}
void PageClientImpl::setCursor(const Cursor& cursor)
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (131346 => 131347)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-10-15 20:22:03 UTC (rev 131346)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-10-15 20:23:51 UTC (rev 131347)
@@ -1155,6 +1155,17 @@
evas_object_smart_callback_call(ewkView, "title,changed", const_cast<char*>(title));
}
+/**
+ * @internal
+ */
+void ewk_view_tooltip_text_set(Evas_Object* ewkView, const char* text)
+{
+ if (text && *text)
+ evas_object_smart_callback_call(ewkView, "tooltip,text,set", const_cast<char*>(text));
+ else
+ evas_object_smart_callback_call(ewkView, "tooltip,text,unset", 0);
+}
+
double ewk_view_load_progress_get(const Evas_Object* ewkView)
{
EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1.0);
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h (131346 => 131347)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-10-15 20:22:03 UTC (rev 131346)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-10-15 20:23:51 UTC (rev 131347)
@@ -65,6 +65,8 @@
* - "resource,request,sent", const Ewk_Resource_Request*: a resource request was sent.
* - "text,found", unsigned int*: the requested text was found and it gives the number of matches.
* - "title,changed", const char*: title of the main frame was changed.
+ * - "tooltip,text,set", const char*: tooltip was set.
+ * - "tooltip,text,unset", void: tooltip was unset.
* - "url,changed", const char*: url of the main frame was changed.
* - "webprocess,crashed", Eina_Bool*: expects a @c EINA_TRUE if web process crash is handled; @c EINA_FALSE, otherwise.
*/
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_private.h (131346 => 131347)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_private.h 2012-10-15 20:22:03 UTC (rev 131346)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_private.h 2012-10-15 20:23:51 UTC (rev 131347)
@@ -76,6 +76,7 @@
void ewk_view_page_close(Evas_Object* ewkView);
WKPageRef ewk_view_page_create(Evas_Object* ewkView);
void ewk_view_title_changed(Evas_Object* ewkView, const char* title);
+void ewk_view_tooltip_text_set(Evas_Object* ewkView, const char* text);
void ewk_view_resource_load_failed(Evas_Object* ewkView, uint64_t resourceIdentifier, Ewk_Error* error);
void ewk_view_resource_load_finished(Evas_Object* ewkView, uint64_t resourceIdentifier);
void ewk_view_resource_load_initiated(Evas_Object* ewkView, uint64_t resourceIdentifier, Ewk_Resource* resource, Ewk_Url_Request* request);
