Title: [131496] trunk
Revision
131496
Author
[email protected]
Date
2012-10-16 13:59:07 -0700 (Tue, 16 Oct 2012)

Log Message

Remove Platform.h include from the header files.
https://bugs.webkit.org/show_bug.cgi?id=98665

Patch by Dima Gorbik <[email protected]> on 2012-10-16
Reviewed by Eric Seidel.

We don't want other clients that include WebKit headers to know about Platform.h.

Source/_javascript_Core:

* API/tests/minidom.c:
* API/tests/testapi.c:

Source/WebCore:

No new tests.

* platform/MemoryPressureHandler.h:
* platform/graphics/filters/arm/FECompositeArithmeticNEON.h:
* platform/graphics/filters/arm/FEGaussianBlurNEON.h:
* platform/graphics/filters/arm/FELightingNEON.h:

Source/WTF:

* wtf/Assertions.h:
* wtf/MainThread.h:

Tools:

* DumpRenderTree/mac/MockGeolocationProvider.mm:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/tests/minidom.c (131495 => 131496)


--- trunk/Source/_javascript_Core/API/tests/minidom.c	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/_javascript_Core/API/tests/minidom.c	2012-10-16 20:59:07 UTC (rev 131496)
@@ -30,6 +30,7 @@
 #include "JSStringRef.h"
 #include <stdio.h>
 #include <stdlib.h>
+#include <wtf/Platform.h>
 #include <wtf/Assertions.h>
 #include <wtf/UnusedParam.h>
 

Modified: trunk/Source/_javascript_Core/API/tests/testapi.c (131495 => 131496)


--- trunk/Source/_javascript_Core/API/tests/testapi.c	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/_javascript_Core/API/tests/testapi.c	2012-10-16 20:59:07 UTC (rev 131496)
@@ -29,6 +29,7 @@
 #include "JSObjectRefPrivate.h"
 #include <math.h>
 #define ASSERT_DISABLED 0
+#include <wtf/Platform.h>
 #include <wtf/Assertions.h>
 #include <wtf/UnusedParam.h>
 

Modified: trunk/Source/_javascript_Core/ChangeLog (131495 => 131496)


--- trunk/Source/_javascript_Core/ChangeLog	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-10-16 20:59:07 UTC (rev 131496)
@@ -1,3 +1,15 @@
+2012-10-16  Dima Gorbik  <[email protected]>
+
+        Remove Platform.h include from the header files.
+        https://bugs.webkit.org/show_bug.cgi?id=98665
+
+        Reviewed by Eric Seidel.
+
+        We don't want other clients that include WebKit headers to know about Platform.h.
+
+        * API/tests/minidom.c:
+        * API/tests/testapi.c:
+
 2012-10-16  Balazs Kilvady  <[email protected]>
 
         Add missing MIPS functions to assembler.

Modified: trunk/Source/WTF/ChangeLog (131495 => 131496)


--- trunk/Source/WTF/ChangeLog	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/WTF/ChangeLog	2012-10-16 20:59:07 UTC (rev 131496)
@@ -1,3 +1,15 @@
+2012-10-16  Dima Gorbik  <[email protected]>
+
+        Remove Platform.h include from the header files.
+        https://bugs.webkit.org/show_bug.cgi?id=98665
+
+        Reviewed by Eric Seidel.
+
+        We don't want other clients that include WebKit headers to know about Platform.h.
+
+        * wtf/Assertions.h:
+        * wtf/MainThread.h:
+
 2012-10-16  Adrienne Walker  <[email protected]>
 
         Remove unused WTF_NEW_HASHMAP_ITERATORS_INTERFACE #define

Modified: trunk/Source/WTF/wtf/Assertions.h (131495 => 131496)


--- trunk/Source/WTF/wtf/Assertions.h	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/WTF/wtf/Assertions.h	2012-10-16 20:59:07 UTC (rev 131496)
@@ -42,8 +42,6 @@
    http://msdn2.microsoft.com/en-us/library/ms177415(VS.80).aspx
 */
 
-#include <wtf/Platform.h>
-
 #include <stddef.h>
 
 #if !COMPILER(MSVC)

Modified: trunk/Source/WTF/wtf/MainThread.h (131495 => 131496)


--- trunk/Source/WTF/wtf/MainThread.h	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/WTF/wtf/MainThread.h	2012-10-16 20:59:07 UTC (rev 131496)
@@ -30,8 +30,6 @@
 #ifndef MainThread_h
 #define MainThread_h
 
-#include <wtf/Platform.h>
-
 #include <stdint.h>
 
 namespace WTF {

Modified: trunk/Source/WebCore/ChangeLog (131495 => 131496)


--- trunk/Source/WebCore/ChangeLog	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 20:59:07 UTC (rev 131496)
@@ -1,3 +1,19 @@
+2012-10-16  Dima Gorbik  <[email protected]>
+
+        Remove Platform.h include from the header files.
+        https://bugs.webkit.org/show_bug.cgi?id=98665
+
+        Reviewed by Eric Seidel.
+
+        We don't want other clients that include WebKit headers to know about Platform.h.
+
+        No new tests.
+
+        * platform/MemoryPressureHandler.h:
+        * platform/graphics/filters/arm/FECompositeArithmeticNEON.h:
+        * platform/graphics/filters/arm/FEGaussianBlurNEON.h:
+        * platform/graphics/filters/arm/FELightingNEON.h:
+
 2012-10-16  Xianzhu Wang  <[email protected]>
 
         [Chromium] Android: Need a way to get appropriate font for some specific characters.

Modified: trunk/Source/WebCore/platform/MemoryPressureHandler.h (131495 => 131496)


--- trunk/Source/WebCore/platform/MemoryPressureHandler.h	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/WebCore/platform/MemoryPressureHandler.h	2012-10-16 20:59:07 UTC (rev 131496)
@@ -28,7 +28,6 @@
 
 #include <time.h>
 #include <wtf/FastAllocBase.h>
-#include <wtf/Platform.h>
 
 namespace WebCore {
 

Modified: trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h (131495 => 131496)


--- trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h	2012-10-16 20:59:07 UTC (rev 131496)
@@ -27,8 +27,6 @@
 #ifndef FECompositeArithmeticNEON_h
 #define FECompositeArithmeticNEON_h
 
-#include <wtf/Platform.h>
-
 #if ENABLE(FILTERS) && HAVE(ARM_NEON_INTRINSICS)
 
 #include "FEComposite.h"

Modified: trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h (131495 => 131496)


--- trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h	2012-10-16 20:59:07 UTC (rev 131496)
@@ -27,8 +27,6 @@
 #ifndef FEGaussianBlurNEON_h
 #define FEGaussianBlurNEON_h
 
-#include <wtf/Platform.h>
-
 #if ENABLE(FILTERS) && HAVE(ARM_NEON_INTRINSICS)
 
 #include "FEGaussianBlur.h"

Modified: trunk/Source/WebCore/platform/graphics/filters/arm/FELightingNEON.h (131495 => 131496)


--- trunk/Source/WebCore/platform/graphics/filters/arm/FELightingNEON.h	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Source/WebCore/platform/graphics/filters/arm/FELightingNEON.h	2012-10-16 20:59:07 UTC (rev 131496)
@@ -27,8 +27,6 @@
 #ifndef FELightingNeon_h
 #define FELightingNeon_h
 
-#include <wtf/Platform.h>
-
 #if CPU(ARM_NEON) && CPU(ARM_TRADITIONAL) && COMPILER(GCC)
 
 #include "FELighting.h"

Modified: trunk/Tools/ChangeLog (131495 => 131496)


--- trunk/Tools/ChangeLog	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Tools/ChangeLog	2012-10-16 20:59:07 UTC (rev 131496)
@@ -1,3 +1,14 @@
+2012-10-16  Dima Gorbik  <[email protected]>
+
+        Remove Platform.h include from the header files.
+        https://bugs.webkit.org/show_bug.cgi?id=98665
+
+        Reviewed by Eric Seidel.
+
+        We don't want other clients that include WebKit headers to know about Platform.h.
+
+        * DumpRenderTree/mac/MockGeolocationProvider.mm:
+
 2012-10-16  Tommy Widenflycht  <[email protected]>
 
         MediaStream API: Add the chromium API for RTCDataChannel

Modified: trunk/Tools/DumpRenderTree/mac/MockGeolocationProvider.mm (131495 => 131496)


--- trunk/Tools/DumpRenderTree/mac/MockGeolocationProvider.mm	2012-10-16 20:45:24 UTC (rev 131495)
+++ trunk/Tools/DumpRenderTree/mac/MockGeolocationProvider.mm	2012-10-16 20:59:07 UTC (rev 131496)
@@ -23,9 +23,9 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
 
+#include <wtf/Platform.h>
 #import "MockGeolocationProvider.h"
 
-
 @implementation MockGeolocationProvider
 
 + (MockGeolocationProvider *)shared
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to