Title: [131654] trunk/Source/WebKit2
- Revision
- 131654
- Author
- commit-qu...@webkit.org
- Date
- 2012-10-17 15:14:41 -0700 (Wed, 17 Oct 2012)
Log Message
[EFL][WK2] Memory leak in ewk_download_job_response_set()
https://bugs.webkit.org/show_bug.cgi?id=99621
Patch by Christophe Dumez <christophe.du...@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.
No longer call ewk_url_response_ref() on the response
object in ewk_download_job_response_set() since it will
be ref'd when assigning to the RefPtr member already.
* UIProcess/API/efl/ewk_context_download_client.cpp:
(didReceiveResponse):
* UIProcess/API/efl/ewk_download_job.cpp:
(ewk_download_job_response_set):
* UIProcess/API/efl/ewk_download_job_private.h: Remove several unimplemented functions.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (131653 => 131654)
--- trunk/Source/WebKit2/ChangeLog 2012-10-17 22:08:21 UTC (rev 131653)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-17 22:14:41 UTC (rev 131654)
@@ -1,5 +1,22 @@
2012-10-17 Christophe Dumez <christophe.du...@intel.com>
+ [EFL][WK2] Memory leak in ewk_download_job_response_set()
+ https://bugs.webkit.org/show_bug.cgi?id=99621
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ No longer call ewk_url_response_ref() on the response
+ object in ewk_download_job_response_set() since it will
+ be ref'd when assigning to the RefPtr member already.
+
+ * UIProcess/API/efl/ewk_context_download_client.cpp:
+ (didReceiveResponse):
+ * UIProcess/API/efl/ewk_download_job.cpp:
+ (ewk_download_job_response_set):
+ * UIProcess/API/efl/ewk_download_job_private.h: Remove several unimplemented functions.
+
+2012-10-17 Christophe Dumez <christophe.du...@intel.com>
+
[EFL][WK2] Compilation warning in Ewk_View when accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=99613
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_download_client.cpp (131653 => 131654)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_download_client.cpp 2012-10-17 22:08:21 UTC (rev 131653)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_download_client.cpp 2012-10-17 22:14:41 UTC (rev 131654)
@@ -69,8 +69,7 @@
{
Ewk_Download_Job* download = ewk_context_download_job_get(toEwkContext(clientInfo), toImpl(wkDownload)->downloadID());
ASSERT(download);
- RefPtr<Ewk_Url_Response> response = Ewk_Url_Response::create(wkResponse);
- ewk_download_job_response_set(download, response.get());
+ ewk_download_job_response_set(download, Ewk_Url_Response::create(wkResponse));
}
static void didCreateDestination(WKContextRef, WKDownloadRef wkDownload, WKStringRef /*path*/, const void* clientInfo)
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp (131653 => 131654)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp 2012-10-17 22:08:21 UTC (rev 131653)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp 2012-10-17 22:14:41 UTC (rev 131654)
@@ -174,12 +174,12 @@
* @internal
* Sets the URL @a response for this @a download.
*/
-void ewk_download_job_response_set(Ewk_Download_Job* download, Ewk_Url_Response* response)
+void ewk_download_job_response_set(Ewk_Download_Job* download, PassRefPtr<Ewk_Url_Response> response)
{
EINA_SAFETY_ON_NULL_RETURN(download);
EINA_SAFETY_ON_NULL_RETURN(response);
- download->response = ewk_url_response_ref(response);
+ download->response = response;
}
/**
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h (131653 => 131654)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h 2012-10-17 22:08:21 UTC (rev 131653)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h 2012-10-17 22:14:41 UTC (rev 131654)
@@ -75,15 +75,9 @@
uint64_t ewk_download_job_id_get(const Ewk_Download_Job*);
Evas_Object* ewk_download_job_view_get(const Ewk_Download_Job*);
-
void ewk_download_job_state_set(Ewk_Download_Job*, Ewk_Download_Job_State);
-void ewk_download_job_cancelled(Ewk_Download_Job*);
-void ewk_download_job_failed(Ewk_Download_Job*);
-void ewk_download_job_finished(Ewk_Download_Job*);
-void ewk_download_job_started(Ewk_Download_Job*);
-
void ewk_download_job_received_data(Ewk_Download_Job*, uint64_t length);
-void ewk_download_job_response_set(Ewk_Download_Job*, Ewk_Url_Response*);
+void ewk_download_job_response_set(Ewk_Download_Job*, PassRefPtr<Ewk_Url_Response>);
void ewk_download_job_suggested_filename_set(Ewk_Download_Job*, const char* suggestedFilename);
#endif // ewk_download_job_private_h
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
