Title: [131823] trunk
- Revision
- 131823
- Author
- wjmacl...@chromium.org
- Date
- 2012-10-18 16:39:18 -0700 (Thu, 18 Oct 2012)
Log Message
[chromium] Re-enable gesture highlight layout tests, fix GestureLongPress regression.
https://bugs.webkit.org/show_bug.cgi?id=99632
Reviewed by James Robinson.
Re-enable layout tests for gesture highlights. Includes fix for GestureTapCancel test.
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
LayoutTests:
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html:
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (131822 => 131823)
--- trunk/LayoutTests/ChangeLog 2012-10-18 23:37:40 UTC (rev 131822)
+++ trunk/LayoutTests/ChangeLog 2012-10-18 23:39:18 UTC (rev 131823)
@@ -1,3 +1,15 @@
+2012-10-18 W. James MacLean <wjmacl...@chromium.org>
+
+ [chromium] Re-enable gesture highlight layout tests, fix GestureLongPress regression.
+ https://bugs.webkit.org/show_bug.cgi?id=99632
+
+ Reviewed by James Robinson.
+
+ Re-enable layout tests for gesture highlights. Includes fix for GestureTapCancel test.
+
+ * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html:
+ * platform/chromium/TestExpectations:
+
2012-10-18 Dirk Pranke <dpra...@chromium.org>
[chromium] fix lint errors/conflicts in ML TestExpectations
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (131822 => 131823)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-18 23:37:40 UTC (rev 131822)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-18 23:39:18 UTC (rev 131823)
@@ -3838,9 +3838,6 @@
webkit.org/b/95617 fast/js/function-constructor-this-value.html [ Failure Pass ]
-# These tests appear to be making bots flaky. See bug for details.
-webkit.org/b/96951 platform/chromium-linux/compositing/gestures [ Skip ]
-
# Does not yet support new web notifications TestRunner API
webkit.org/b/95506 http/tests/notifications
Modified: trunk/LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html (131822 => 131823)
--- trunk/LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html 2012-10-18 23:37:40 UTC (rev 131822)
+++ trunk/LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html 2012-10-18 23:39:18 UTC (rev 131823)
@@ -24,7 +24,6 @@
if (window.eventSender) {
// Generate valid link highlight.
eventSender.gestureTapDown(x, y);
- window.testRunner.display();
// Generate long press ... this should cancel highlight.
eventSender.gestureLongPress(x, y);
Modified: trunk/Source/WebKit/chromium/ChangeLog (131822 => 131823)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-10-18 23:37:40 UTC (rev 131822)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-18 23:39:18 UTC (rev 131823)
@@ -1,3 +1,15 @@
+2012-10-18 W. James MacLean <wjmacl...@chromium.org>
+
+ [chromium] Re-enable gesture highlight layout tests, fix GestureLongPress regression.
+ https://bugs.webkit.org/show_bug.cgi?id=99632
+
+ Reviewed by James Robinson.
+
+ Re-enable layout tests for gesture highlights. Includes fix for GestureTapCancel test.
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::handleGestureEvent):
+
2012-10-18 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r131810.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (131822 => 131823)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-10-18 23:37:40 UTC (rev 131822)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-10-18 23:39:18 UTC (rev 131823)
@@ -679,6 +679,7 @@
m_linkHighlight->startHighlightAnimationIfNeeded();
break;
case WebInputEvent::GestureTap:
+ case WebInputEvent::GestureLongPress:
// If a link highlight is active, kill it.
m_linkHighlight.clear();
break;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
