Title: [131942] trunk
- Revision
- 131942
- Author
- mrobin...@webkit.org
- Date
- 2012-10-19 14:02:29 -0700 (Fri, 19 Oct 2012)
Log Message
REGRESSION (r130699): 5 various fast/ tests started failing
https://bugs.webkit.org/show_bug.cgi?id=98729
Reviewed by Xan Lopez.
Source/WebCore:
Do not try to remove the URL fragment for data URLs. This will likely
just corrupt the URL.
No new tests. This unskips some previously failing tests.
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::urlStringForSoup): Do nothing for data URLs.
LayoutTests:
Unskip some tests which are now passing.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (131941 => 131942)
--- trunk/LayoutTests/ChangeLog 2012-10-19 20:47:15 UTC (rev 131941)
+++ trunk/LayoutTests/ChangeLog 2012-10-19 21:02:29 UTC (rev 131942)
@@ -1,3 +1,14 @@
+2012-10-09 Martin Robinson <mrobin...@igalia.com>
+
+ REGRESSION (r130699): 5 various fast/ tests started failing
+ https://bugs.webkit.org/show_bug.cgi?id=98729
+
+ Reviewed by Xan Lopez.
+
+ Unskip some tests which are now passing.
+
+ * platform/gtk/TestExpectations:
+
2012-10-19 Emil A Eklund <e...@chromium.org>
Unreviewed gardening.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (131941 => 131942)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-10-19 20:47:15 UTC (rev 131941)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-10-19 21:02:29 UTC (rev 131942)
@@ -1365,13 +1365,6 @@
webkit.org/b/98613 css3/masking/clip-path-reference-userSpaceOnUse.html [ ImageOnlyFailure ]
webkit.org/b/98613 css3/masking/clip-path-reference.html [ ImageOnlyFailure ]
-webkit.org/b/98729 fast/css/import-style-update.html [ Failure ]
-webkit.org/b/98729 fast/html/link-rel-stylesheet.html [ Failure ]
-webkit.org/b/98729 fast/loader/data-url-encoding-html.html [ Failure ]
-webkit.org/b/98729 fast/loader/data-url-encoding-svg.html [ Failure ]
-webkit.org/b/98729 fast/spatial-navigation/snav-iframe-nested.html [ Failure ]
-webkit.org/b/98729 svg/custom/object-data-href.html [ ImageOnlyFailure ]
-
# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms
webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html
Modified: trunk/Source/WebCore/ChangeLog (131941 => 131942)
--- trunk/Source/WebCore/ChangeLog 2012-10-19 20:47:15 UTC (rev 131941)
+++ trunk/Source/WebCore/ChangeLog 2012-10-19 21:02:29 UTC (rev 131942)
@@ -1,3 +1,18 @@
+2012-10-09 Martin Robinson <mrobin...@igalia.com>
+
+ REGRESSION (r130699): 5 various fast/ tests started failing
+ https://bugs.webkit.org/show_bug.cgi?id=98729
+
+ Reviewed by Xan Lopez.
+
+ Do not try to remove the URL fragment for data URLs. This will likely
+ just corrupt the URL.
+
+ No new tests. This unskips some previously failing tests.
+
+ * platform/network/soup/ResourceRequestSoup.cpp:
+ (WebCore::ResourceRequest::urlStringForSoup): Do nothing for data URLs.
+
2012-10-19 Simon Fraser <simon.fra...@apple.com>
Use tile caches in place of CATiledLayer
Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp (131941 => 131942)
--- trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2012-10-19 20:47:15 UTC (rev 131941)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2012-10-19 21:02:29 UTC (rev 131942)
@@ -126,6 +126,16 @@
String ResourceRequest::urlStringForSoup() const
{
+ // WebKit does not support fragment identifiers in data URLs, but soup does.
+ // Before passing the URL to soup, we should make sure to urlencode any '#'
+ // characters, so that soup does not interpret them as fragment identifiers.
+ // See http://wkbug.com/68089
+ if (m_url.protocolIsData()) {
+ String urlString = m_url.string();
+ urlString.replace("#", "%23");
+ return urlString;
+ }
+
KURL url = ""
url.removeFragmentIdentifier();
return url.string();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
