Title: [132120] trunk
- Revision
- 132120
- Author
- ander...@apple.com
- Date
- 2012-10-22 12:23:52 -0700 (Mon, 22 Oct 2012)
Log Message
[WK2] Regression(r131990): plugins/npruntime/remove-property.html started failing
https://bugs.webkit.org/show_bug.cgi?id=99977
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Remove int32_t casts - the ArgumentDecoder::decode overload that takes a const int would cause
a temporary to be created which the number was then decoded into.
* Shared/Plugins/NPIdentifierData.cpp:
(WebKit::NPIdentifierData::encode):
(WebKit::NPIdentifierData::decode):
LayoutTests:
Remove now passing test.
* platform/efl-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (132119 => 132120)
--- trunk/LayoutTests/ChangeLog 2012-10-22 19:21:03 UTC (rev 132119)
+++ trunk/LayoutTests/ChangeLog 2012-10-22 19:23:52 UTC (rev 132120)
@@ -1,3 +1,14 @@
+2012-10-22 Anders Carlsson <ander...@apple.com>
+
+ [WK2] Regression(r131990): plugins/npruntime/remove-property.html started failing
+ https://bugs.webkit.org/show_bug.cgi?id=99977
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove now passing test.
+
+ * platform/efl-wk2/TestExpectations:
+
2012-10-22 Varun Jain <varunj...@chromium.org>
Context menu generated from touch gestures on textareas has
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (132119 => 132120)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-10-22 19:21:03 UTC (rev 132119)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-10-22 19:23:52 UTC (rev 132120)
@@ -247,9 +247,6 @@
# NPP_SetWindow is not called during plugin destruction on X11.
webkit.org/b/63261 plugins/npp-set-window-called-during-destruction.html [ Failure ]
-# Test started failing on all WK2 ports after r131990.
-webkit.org/b/99977 plugins/npruntime/remove-property.html [ Failure ]
-
# Delete plugin failures.
webkit.org/b/98740 plugins/npruntime/delete-plugin-within-hasProperty-return-false.html [ Failure ]
webkit.org/b/98740 plugins/npruntime/delete-plugin-within-hasProperty-return-true.html [ Failure ]
Modified: trunk/Source/WebKit2/ChangeLog (132119 => 132120)
--- trunk/Source/WebKit2/ChangeLog 2012-10-22 19:21:03 UTC (rev 132119)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-22 19:23:52 UTC (rev 132120)
@@ -1,5 +1,19 @@
2012-10-22 Anders Carlsson <ander...@apple.com>
+ [WK2] Regression(r131990): plugins/npruntime/remove-property.html started failing
+ https://bugs.webkit.org/show_bug.cgi?id=99977
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove int32_t casts - the ArgumentDecoder::decode overload that takes a const int would cause
+ a temporary to be created which the number was then decoded into.
+
+ * Shared/Plugins/NPIdentifierData.cpp:
+ (WebKit::NPIdentifierData::encode):
+ (WebKit::NPIdentifierData::decode):
+
+2012-10-22 Anders Carlsson <ander...@apple.com>
+
Don't use CStrings for message receiver names and message names
https://bugs.webkit.org/show_bug.cgi?id=99853
Modified: trunk/Source/WebKit2/Shared/Plugins/NPIdentifierData.cpp (132119 => 132120)
--- trunk/Source/WebKit2/Shared/Plugins/NPIdentifierData.cpp 2012-10-22 19:21:03 UTC (rev 132119)
+++ trunk/Source/WebKit2/Shared/Plugins/NPIdentifierData.cpp 2012-10-22 19:23:52 UTC (rev 132120)
@@ -73,7 +73,7 @@
if (m_isString)
encoder->encode(m_string);
else
- encoder->encode(static_cast<int32_t>(m_number));
+ encoder->encode(m_number);
}
bool NPIdentifierData::decode(CoreIPC::ArgumentDecoder* decoder, NPIdentifierData& result)
@@ -84,7 +84,7 @@
if (result.m_isString)
return decoder->decode(result.m_string);
- return decoder->decode(static_cast<int32_t>(result.m_number));
+ return decoder->decode(result.m_number);
}
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
